Windows 10/File Explorer: recognize ApplicationFrameWindow as UIA object so first selected emoji and cloud clipboard item can be announced in May 2019 Update and later#10375
Merged
michaelDCurran merged 3 commits intoOct 21, 2019
Conversation
…and later. Re nvaccess#9204. In build 18305 and later, it is File Explorer that raises window open event for modern keyboard. Because of this, when emoji panel and related panels open, first selected item will not be announced. Thus: * Recognize the top-level modern input window as proper UIA item. Although a 'Close' button is next to it, not all input features will be accompanied with this - emoji panel does but dictation does not. * If window open event is fired from File Explorer, make sure that the child window is indeed a modern input window.
lukaszgo1
reviewed
Oct 15, 2019
| import time | ||
| import appModuleHandler | ||
| import controlTypes | ||
| import winVersion |
Contributor
There was a problem hiding this comment.
This import isn't necessary -- winVersion is already imported a few lines below.
Contributor
Author
|
Hi, you’re right. Thanks.
From: Łukasz Golonka <notifications@github.com>
Sent: Tuesday, October 15, 2019 6:01 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [nvaccess/nvda] Windows 10/File Explorer: recognize ApplicationFrameWindow as UIA object so first selected emoji and cloud clipboard item can be announced in May 2019 Update and later (#10375)
@lukaszgo1 commented on this pull request.
_____
In source/appModules/explorer.py <#10375 (comment)> :
Provides workarounds for controls such as identifying Start button, notification area and others.
"""
from comtypes import COMError
import time
import appModuleHandler
import controlTypes
+import winVersion
This import isn't necessary -- winVersion is already imported a few lines below.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#10375?email_source=notifications&email_token=AB4AXEABCMCTGJKEVNR5W7TQOW5KFA5CNFSM4JABR2PKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCH7G6CA#pullrequestreview-301887240> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4AXEB5TIVNB7HYLE2OOKLQOW5KFANCNFSM4JABR2PA> .
|
michaelDCurran
approved these changes
Oct 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Note: this is a smaller version of #9205
Link to issue number:
Fixes #9204
Summary of the issue:
In Windows 10 Version 1903 (May 2019 Update) and later, when emoji panel or cloud clipboard opens, first selected item is not announced because UIA window open event is fired by File Explorer.
Description of how this pull request fixes the issue:
Allow ApplicationFrameWindow in File Explorer to be recognized as a UIA object so UIA window open event can be detected for it, which will then be forwarded to modern keyboard so first selected item can be announced for emoji panel and clipboard history.
Testing performed:
Tested via Windows 10 App Essentials on Version 1903 and later.
Known issues with pull request:
None
Change log entry:
Bug fixes:
In Windows 10 May 2019 Update and later, NVDA will once again announce first selected emoji or clipboard item when emoji panel and clipboard history opens, respectively. (#9204)