Skip to content

Report hidden formatting in MS Word#10313

Merged
michaelDCurran merged 3 commits into
nvaccess:masterfrom
CyrilleB79:wordReportHidden
Oct 7, 2019
Merged

Report hidden formatting in MS Word#10313
michaelDCurran merged 3 commits into
nvaccess:masterfrom
CyrilleB79:wordReportHidden

Conversation

@CyrilleB79

@CyrilleB79 CyrilleB79 commented Oct 2, 2019

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #8713

Summary of the issue:

Hidden font formatting is not reported in MS Word (when nonprinting characters are displayed)

Description of how this pull request fixes the issue:

Get the hidden attribute of character at the cursor as done for italic or bold for example.

Testing performed:

Tested under Word 2016 and Outlook 2016 message with nonprinting characters displayed:

  • put the cursor in hidden text and press NVDA+F one or two times: hidden is reported correctly
  • put the cursor in non hidden text (normal) and press NVDA+F one or two times: hidden is not reported as expected
  • with font attributes reporting enabled, move the cursor with left/right arrow keys into or out of hidden text: "hidden" and "no hidden" is reported when expected

Known issues with pull request:

None

Change log entry:

Changes
Hidden font formatting is now reported in Microsoft Word. (#8713)

@AppVeyorBot

AppVeyorBot commented Oct 2, 2019

Copy link
Copy Markdown

PR introduces Flake8 errors 😲

See test results for Failed build of commit f3aaa9c087

LeonarddeR
LeonarddeR reviewed Oct 3, 2019
View reviewed changes
Comment thread source/speech/__init__.py Outdated
@CyrilleB79

CyrilleB79 commented Oct 3, 2019

Copy link
Copy Markdown
Contributor Author

Flake8 fails with the following message:

source/speech/init.py:1579:5: ET128 (flake8-tabs) unexpected number of tabs and spaces at start of expression line (expected 3 tabs and 8 spaces, got 4 tabs and 0 spaces)

Why does Flake8 say that it expects mixed tabs and spaces (3 tabs and 8 spaces) ?

@feerrenrut any thought? Thanks.

@CyrilleB79 @LeonarddeR
Update source/speech/__init__.py
e80765e 
Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com>
@CyrilleB79

CyrilleB79 commented Oct 3, 2019

Copy link
Copy Markdown
Contributor Author

@LeonarddeR thanks for suggestion. You are right actually, it is "no bold" or "no italic", but "not underlined", i.e. "not" with a verb in past participle.

@AppVeyorBot

AppVeyorBot commented Oct 3, 2019

Copy link
Copy Markdown

PR introduces Flake8 errors 😲

See test results for Failed build of commit 128b074015

@CyrilleB79

CyrilleB79 commented Oct 3, 2019

Copy link
Copy Markdown
Contributor Author

Linting issue fixed.
Sorry to have disturbed.
The Flake8 message was not explicit at all but this behavior was already described in NVDA's linting process description.
The message deals with spaces and tabs but actually regards "hanging indent" style.

@michaelDCurran michaelDCurran merged commit a157fbd into nvaccess:master Oct 7, 2019
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Oct 7, 2019
michaelDCurran added a commit that referenced this pull request Oct 7, 2019
@michaelDCurran
Update changes file for pr #10313.
49365d1
@CyrilleB79 CyrilleB79 deleted the wordReportHidden branch June 10, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelDCurran michaelDCurran michaelDCurran approved these changes

+1 more reviewer

@LeonarddeR LeonarddeR LeonarddeR left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2019.3

Development

Successfully merging this pull request may close these issues.

NVDA does not report that text is "hidden" when show formatting is enabled in Word (365 at least)

5 participants

@CyrilleB79 @AppVeyorBot @LeonarddeR @michaelDCurran @nvaccessAuto