Fix up of: NVDA logging: add originating thread to log entry (#10259, #10266)#10269
Closed
JulienCochuyt wants to merge 1 commit into
Closed
Fix up of: NVDA logging: add originating thread to log entry (#10259, #10266)#10269JulienCochuyt wants to merge 1 commit into
JulienCochuyt wants to merge 1 commit into
Conversation
Collaborator
|
Duplicate of #10267 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10266
Fix up of #10259
Alternative to PR #10267
Summary of the issue:
PR #10259 introduced a regression by setting the name of thread
gui.ExecAndPumpbefore initializing it.Description of how this pull request fixes the issue:
Pass the name of the thread in the initializer super call.
Testing performed:
Reproduced the issue described in #10266 without this fix.
Checked this does not reproduce once the present fix is applied.
Known issues with pull request:
Change log entry:
N/A
cc @LeonarddeR
cc @michaelDCurran