NVDA logging: add originating thread to log entry#10259
Merged
Conversation
Contributor
|
@LeonarddeR, thanks a lot for this PR! |
JulienCochuyt
added a commit
to accessolutions/nvda
that referenced
this pull request
Sep 21, 2019
Contributor
|
@LeonarddeR, please find in BabbageCom/nvda#10 my suggestion to generalize the use of fully qualified names. |
Collaborator
Author
|
Thanks for doing this. It's fine how you did it. I have one review
suggestion and as soon as that's applied, I will merge this.
|
…) (#10) * Thread name logging: Generalize logging of full qualified names (#10259) * Review action https://github.com/BabbageCom/nvda/pull/10#discussion_r326867603 Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com>
Collaborator
Author
|
@michaelDCurran: @JulienCochuyt filed a pr against this pr, which has been merged into it. I think this is ready for review. Would be pretty helpful to debug #10247, probably. |
michaelDCurran
approved these changes
Sep 23, 2019
michaelDCurran
added a commit
that referenced
this pull request
Sep 23, 2019
JulienCochuyt
added a commit
to accessolutions/nvda
that referenced
this pull request
Sep 23, 2019
JulienCochuyt
added a commit
to accessolutions/nvda
that referenced
this pull request
Sep 23, 2019
…s#10259) `__module__` is `None` for functions defined in the Python console.
JulienCochuyt
added a commit
to accessolutions/nvda
that referenced
this pull request
Oct 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None. Hopefully helps debugging #10247
Summary of the issue:
As NVDA is getting a larger application, there are multiple threads involved in its operation. Logging can also be initiated from multiple threads. However, in the current situation,, we do not know from what thread a log entry is coming. Knowing the originating thread helps in following the flow in a log file.
Description of how this pull request fixes the issue:
Testing performed:
Tested that NVDA still runs and appropriate thread info is logged. Paid extra attention to watchdog.CancellableCallThread to set the name of the thread to the function it is being executed with.
Known issues with pull request:
None
Change log entry: