Vocalize the shortcut to toggle displaying nonprintable characcters i…#10242
Conversation
JulienCochuyt
left a comment
There was a problem hiding this comment.
Please use the new script method decorator instead of the legacy __gestures dictionary.
| ui.message(_("Change tracking off")) | ||
|
|
||
|
|
||
| def script_toggleDisplayNonprintingCharacters(self, gesture): |
There was a problem hiding this comment.
| def script_toggleDisplayNonprintingCharacters(self, gesture): | |
| @script(gesture="kb:control+shift+8") | |
| def script_toggleDisplayNonprintingCharacters(self, gesture): |
| "kb:control+2":"changeLineSpacing", | ||
| "kb:control+5":"changeLineSpacing", | ||
| "kb:control+shift+e": "toggleChangeTracking", | ||
| "kb:control+shift+8": "toggleDisplayNonprintingCharacters", |
There was a problem hiding this comment.
| "kb:control+shift+8": "toggleDisplayNonprintingCharacters", |
|
@JulienCochuyt |
Indeed, but no problem at all. |
|
Another point: Proposal 1: Proposal 2: |
|
Proposal 1 is the best as "chars" certainly may not be understood by many users. |
Link to issue number:
Fixes #10241
Summary of the issue:
In an MS Word Document, look at the end of a paragraph and press Ctrl+Shift+8 (main keyboard) 2 or 3 times. You will see the end of paragraph mark appear and disappear but NVDA does not give a vocal feedback of this action.
Description of how this pull request fixes the issue:
NVDA announces the state of displaying nonprinting characters when the toggle shortcut Ctrl+Shift+8 is executed.
Testing performed:
In a Word document pressed Ctrl+Shift+8 various times.
Blind check
NVDA announce "Display nonprinting character on" or "off" when the shortcut is executed. After each gesture, I have checked in the Home ribbon, group paragraph that the state of "Show all" button is in accordance with the previously announced state.
Visual check
I have checked that NVDA announce "Display nonprinting character on" or "off" when end of paragraph and space marks appear and disappear at the same time.
Known issues with pull request:
None
Change log entry:
Changes
NVDA now announces the state of display non printing character when pressing the toggle shortcut Ctrl+Shift+8 . (#10241)