port of pr 10153 into beta.#10234
Merged
Merged
Conversation
|
Was there not a second fix for a problem with the mouse being used in
certain circumstances? This was the most annoying one we had, since sighted
rather than turn off nvda, merely muted the sound then had nearly 50
explorer crashes in 10 minutes.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal E-mail to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users
----- Original Message -----
From: "Łukasz Golonka" <notifications@github.com>
To: "nvaccess/nvda" <nvda@noreply.github.com>
Cc: "Subscribed" <subscribed@noreply.github.com>
…Sent: Tuesday, September 17, 2019 10:58 AM
Subject: [nvaccess/nvda] port of pr 10153 into beta. (#10234)
### Link to issue number:
Fixes #5337 port of #10153 into beta.
### Testing performed:
Ensured that the crash no longer occurs.
### Known issues with pull request:
None
### Change log entry:
Same as in #5337
You can view, comment on, or merge this pull request online at:
#10234
-- Commit Summary --
* port of pr 10153 into beta.
-- File Changes --
M source/appModules/explorer.py (19)
-- Patch Links --
https://github.com/nvaccess/nvda/pull/10234.patch
https://github.com/nvaccess/nvda/pull/10234.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#10234
|
LeonarddeR
suggested changes
Sep 17, 2019
Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com>
Contributor
Author
|
@LeonarddeR All done |
LeonarddeR
reviewed
Sep 17, 2019
Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com>
Member
Yes, this is already in the beta branch. |
Member
|
@LeonarddeR I think you have a review pending on this pr. |
LeonarddeR
approved these changes
Sep 23, 2019
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
sorry for missing this @michaelDCurran
michaelDCurran
approved these changes
Sep 23, 2019
michaelDCurran
added a commit
that referenced
this pull request
Sep 23, 2019
LeonarddeR
added a commit
that referenced
this pull request
Nov 20, 2019
* port of pr 10153 into beta. * Update source/appModules/explorer.py Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com> * Update source/appModules/explorer.py Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #5337 port of #10153 into beta.
Testing performed:
Ensured that the crash no longer occurs.
Known issues with pull request:
None
Change log entry:
Same as in #5337