No longer fail to present UI elements in Audacity compressor dialog#10144
Merged
michaelDCurran merged 2 commits intonvaccess:masterfrom Sep 8, 2019
Merged
No longer fail to present UI elements in Audacity compressor dialog#10144michaelDCurran merged 2 commits intonvaccess:masterfrom
michaelDCurran merged 2 commits intonvaccess:masterfrom
Conversation
michaelDCurran
approved these changes
Sep 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10103
Summary of the issue:
In Audacitys compressor dialog all elements are inside a group with class button, and no name. In its app module ampersand sign in name of every object with class button is removed. This unsurprisingly fails for object without name.
Description of how this pull request fixes the issue:
If the object has no name do not perform a replacement.
Testing performed:
Performed str from #10103. Ensured that elements of the dialog are read.
Known issues with pull request:
None
Change log entry:
Section: Bug fixes
controls in Audacitys compressor dialog are now announced when navigating the dialog.