No longer use UIA rangeFromPoint in windows 7 to avoid explorer crash in start menu#10104
Merged
Conversation
|
Hi when will a snap with this fix be around? I could do with installing it
on a machine in our studio as its used by sighted people a lot and I am
getting complaints!!
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal E-mail to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users
|
|
@LeonarddeR: Having this fix in NVDA 2019.2.1 together with a fix for issue #9982 would be great. Otherwise: Is it possible to replace that "init.pyo" from Try-Build 18422 in the file "library.zip" by using 7-Zip? |
Collaborator
Author
|
This issue can be worked around by disabling mouse tracking and not
using mouse tracking in the start menu. #9982 will be pretty hard to
fix, and as it is no longer reproducible in alpha versions of NVDA< it
is not very likely that anyone of the main developers will invest time
in it.
|
|
Hi, I see the try build uses Python 3, it would have been nice to have this
fixed for a release of the current stable.
However I have now downloaded it, and put the add ons from my alpha into
it.
I have had to disable add on updater as it gives an error on startup.
However several other queries I have to ask about as the machine I'll be
trying it on is not with me here for monitoring.
Are any of these anything to worry about?
WARNING - baseObject.Getter.__init__ (20:09:30.331):
Abstract class properties are not supported.
snip
DEBUG - core.main (20:09:30.558):
Initializing vision
Is this a new subroutine?
DEBUG - core.main (20:09:30.558):
Initializing displayModel
DEBUG - core.main (20:09:30.559):
Initializing GUI
DEBUG - windowUtils._rawWindowProc (20:09:30.566):
CustomWindow rawWindowProc called for unknown window 852974
DEBUG - windowUtils._rawWindowProc (20:09:30.566):
CustomWindow rawWindowProc called for unknown window 852974
DEBUG - windowUtils._rawWindowProc (20:09:30.566):
CustomWindow rawWindowProc called for unknown window 852974
DEBUG - windowUtils._rawWindowProc (20:09:30.567):
CustomWindow rawWindowProc called for unknown window 852974
DEBUG - core.main (20:09:30.569):
snip
During startup. I do have the same add ons installed as I do with alpha
snaps.
I note that no add on or nvda updates supported by try builds, so have
disabled add on updater as it was generating errors at start up
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal E-mail to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users
-----
|
Collaborator
Author
|
This problem was introduced in NVDA 2019.1, therefore creating a 2019.2.1 only because of this issue while there is a workaround sounds a bit too much to me. We could always consider fixing this for a 2019.2.1 if another, more serious issue pops up that justifies a point release. @feerrenrut might have a different opinion, though. |
|
Well I know it never used to happen, but its been unclear quite when it
started Its because its such a flaky thing to trigger.
This all came to a head about a month ago when Explorer crashed 47 times in
half an hour and turning off nvda and loading in a very old portable version
fixed it. Quite why it suddenly happened so often I have no idea, maybe
because of the fact that one of our sighted folk merely turned off the audio
rather then shutting nvda down. I cannot say, as I was not there at the
time, but I guess if I tell them all to unload nvda when using the mouse to
navigate generally, they should be safe.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal E-mail to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users
-----
|
Issue #9982 would be one. And please also think about magnifier users, which primary still use the mouse. |
michaelDCurran
approved these changes
Sep 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9435
Summary of the issue:
In #8572, we introduced much more reliable mouse tracking for UIA text ranges. However, it seems that mouse tracking in the Windows 7 start menu search field causes a crash in the UIA client library, crashing explorer and causing NVDA to freeze.
Description of how this pull request fixes the issue:
As before, no longer allow UIA rangeFromPoint to be called when on Windows 7.
Testing performed:
T.b.d.
Known issues with pull request:
None
Change log entry: