Touch gestures: add right mouse click (tap and hold) command#10065
Merged
Conversation
Contributor
Author
|
Hi, Also, if you can: @LeonarddeR and @michaelDCurran Thanks. |
Contributor
Author
|
Hi, As for improving review activate script to do a left mouse click: I think it should be a separate pull request, because the discussion we had five years ago may need some tweaking, as well as allowing all input mechanisms (keyboard, mouse, braille, touch, etc.) to take advantage of solutions proposed in #3886 in one sweep. Thanks. |
Collaborator
|
There is an issue of terminology here.
By "tap and hold", is this what apple calls a "double tap and hold"? In other
words: tap with one finger, lift the finger, put it down again, and leave it
there the second time?
So that your finger actually "taps" the screen twice, with the second being
rather longer than the first?
Or is it truly a tap and hold (single tap and hold): lower the finger once, and
leave it there?
I can't imagine it's the latter, since that would be indistinguishable from a
location adjust gesture.
|
Contributor
Author
|
Hi, yes, the former is what NVDA uses as well. Thanks.
From: Luke Davis <notifications@github.com>
Sent: Friday, August 9, 2019 4:10 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [nvaccess/nvda] Touch gestures: add right mouse click (tap and hold) command (#10065)
There is an issue of terminology here.
By "tap and hold", is this what apple calls a "double tap and hold"? In other
words: tap with one finger, lift the finger, put it down again, and leave it
there the second time?
So that your finger actually "taps" the screen twice, with the second being
rather longer than the first?
Or is it truly a tap and hold (single tap and hold): lower the finger once, and
leave it there?
I can't imagine it's the latter, since that would be indistinguishable from a
location adjust gesture.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#10065?email_source=notifications&email_token=AB4AXED2OGBDXQMYXOA7B5DQDX2MXA5CNFSM4IKXL6BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD377PUQ#issuecomment-520091602> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4AXECIUSGKVRW7VFHMU4DQDX2MXANCNFSM4IKXL6BA> .
|
…jects, as well as if any of the object coordinates is negative. re nvaccess#3886. In some cases, objects may appear invisible until focus moves to it. This is noticeable on www.webaim.org's skip to content anchor. Also don't bother clicking when the minimum of the coordinates is negative. Also modified script doc for touch_rightClick (all suggested by jamie@nvaccess.org).
…ces, reword introductory text for mouse commands table. Re nvaccess#3886
Lint fixes include spaces around operators, dictionary key/value assignment, and three noqa comments.
Contributor
Author
|
Hi, I think it is ready for another round of reviews and comments, now that 2019.3 has been released. Thanks. |
michaelDCurran
approved these changes
Feb 16, 2020
Collaborator
|
@josephsl please don't forget to add the coresponding touch gesture into the user guide, section 5.7. Thanks. |
Contributor
Author
|
Hi, I thought I did, but it looks like I may have not. Thanks.
From: Adriani90 <notifications@github.com>
Sent: Monday, February 17, 2020 3:26 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [nvaccess/nvda] Touch gestures: add right mouse click (tap and hold) command (#10065)
@josephsl <https://github.com/josephsl> please don't forget to add the coresponding touch gesture into the user guide, section 5.7. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#10065?email_source=notifications&email_token=AB4AXEBTMS3AQ6KSPZUZDVDRDMMH7A5CNFSM4IKXL6BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL74YTQ#issuecomment-587189326> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4AXEAYIUXUOXYACWGZ2YTRDMMH7ANCNFSM4IKXL6BA> .
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Another pull request that was buried for a very long time, now resurrected:
Link to issue number:
Fixes #3886
Summary of the issue:
There is no mouse commands for touch users.
Description of how this pull request fixes the issue:
Adds a right mouse click command for touch users: tap and hold.
Testing performed:
Tested as part of Enhanced Touch Gestures add-on.
Known issues with pull request:
None
Change log entry:
New features:
You can now perform right mouse clicks on touch devices by doing a one finger tap and hold. (#3886)