PR introduces Flake8 errors 😲

See test results for Failed build of commit 52fcc10938

PR introduces Flake8 errors 😲

See test results for Failed build of commit 939e177bc6

Some things I observed.

1. The aria comboboxes aren't expandable with alt+down arrow. I expected that that would happen.
2. The third example, opening it and pressing down arrow populates the edit box with apple. ANother press of down arrow focuses the list. This might be expected behavior based on the widget's implementation, though.
3. When the list gets focus instead of the edit box, the name of the control is repeated. I would expected that only list is announced, but again, this might be related to the implementation.

1. The aria comboboxes aren't expandable with alt+down arrow. I expected that that would happen.

Do you mean pressing alt+downArrow from browse mode or focus mode? Those combo boxes seem to have weird behaviour with alt+downArrow. That said, downArrow is usually enough to open an autocomplete if appropriate.

2. The third example, opening it and pressing down arrow populates the edit box with apple. ANother press of down arrow focuses the list. This might be expected behavior based on the widget's implementation, though.

When you say "opening it", do you mean alt+downArrow? That behaves strangely for me with these examples; it seems to open, but when you release alt, it collapses.

3. When the list gets focus instead of the edit box, the name of the control is repeated. I would expected that only list is announced, but again, this might be related to the implementation.

The implementation has the label on both the text box and the list, so yes, this is related to the implementation. If that's common, we could potentially filter this out, but I think that's out of scope for this PR.

1. The aria comboboxes aren't expandable with alt+down arrow. I expected that that would happen.

Do you mean pressing alt+downArrow from browse mode or focus mode? Those combo boxes seem to have weird behaviour with alt+downArrow. That said, downArrow is usually enough to open an autocomplete if appropriate.

In both browse and focus mode.

2. The third example, opening it and pressing down arrow populates the edit box with apple. ANother press of down arrow focuses the list. This might be expected behavior based on the widget's implementation, though.

When you say "opening it", do you mean alt+downArrow? That behaves strangely for me with these examples; it seems to open, but when you release alt, it collapses.

Exact sstr are:

1. Go to the third example in browse mode
2. Press space on the combo box to activate it (switch to focus mode)
3. Press down arrow: I hear apple
4. Press down arrow again, i hear Choice 3 Fruit or Vegetable list, Artichoke

1. The aria comboboxes aren't expandable with alt+down arrow. I expected that that would happen.

Do you mean pressing alt+downArrow from browse mode or focus mode?

In both browse and focus mode.

The fact that this doesn't work in focus mode is because the test cases don't support it. I don't know of any ARIA 1.1 combo boxes that do. They tend to expand when you start typing or when you press down arrow.

My feeling is that we shouldn't do anything for browse mode here unless we can find a combo box that actually supports this. That can be done as a follow-up. Does that work for you?

1. Go to the third example in browse mode

2. Press space on the combo box to activate it (switch to focus mode)

3. Press down arrow: I hear apple

For me, the list gets focus when I press down arrow here. However, I'm using Firefox nightly. I suspect you're being bitten by https://bugzilla.mozilla.org/show_bug.cgi?id=1571327 , which I fixed a month ago (targeting Firefox 70).

My feeling is that we shouldn't do anything for browse mode here unless we can find a combo box that actually supports this. That can be done as a follow-up. Does that work for you?

Sure!

For me, the list gets focus when I press down arrow here. However, I'm using Firefox nightly. I suspect you're being bitten by https://bugzilla.mozilla.org/show_bug.cgi?id=1571327 , which I fixed a month ago (targeting Firefox 70).

Ah, in that case, let's assume it will be fixed in FF70 for me as well.