Log NVDA version number at the top of the log file to make debugging easier#10004
Conversation
|
PR introduces Flake8 errors 😲 See test results for Failed build of commit ca793c64d3 |
| @@ -1,9 +1,9 @@ | |||
| # -*- coding: UTF-8 -*- | |||
| #core.py | |||
There was a problem hiding this comment.
Please restore this line
There was a problem hiding this comment.
@LeonarddeR According to the copyright headers wiki page
Note: We decided to remove the filename comment from the top of the file, since it doesn't really add anything, and is a source of error on file rename / copying copyright headers between files.
If we arre no longer adding it to the new files why shouldn't we remove it from the existing ones during updating of the copyright headers?
|
Ah, this is a good point. Actually I was never pointed at this during a
review.
|
michaelDCurran
left a comment
There was a problem hiding this comment.
If NVDA is started with --log-level 30 or higher, the NVDA version is still not logged. I think that nvda.pyw should initially force the log level to info, log the version, and then set the log level based on the commandline.
|
@michaelDCurran I'm afraid I have to disagree here. |
Link to issue number:
Closes #9803
Summary of the issue:
When testing a issue with various version of NVDA is is useful to have version number easily available in the log file. At the moment it isn't at the top and if log level is set to disabled is not logged at all.
Description of how this pull request fixes the issue:
Version number is moved to the second line of the log and buildVersion is used to retrieve it instead of versionInfo.
Testing performed:
Known issues with pull request:
None
Change log entry:
Section: Changes
The NVDA version number is now logged as the first message in the log. Note that it happens also when logging is disabled from the GUI