Skip to content

Upgrade eSpeak-ng to latest master#8561

Merged
michaelDCurran merged 2 commits into
masterfrom
updateEspeak
Jul 27, 2018
Merged

Upgrade eSpeak-ng to latest master#8561
michaelDCurran merged 2 commits into
masterfrom
updateEspeak

Conversation

@michaelDCurran

Copy link
Copy Markdown
Member

Link to issue number:

None.

Summary of the issue:

With the merging of #7846, NVDA users complained of several issues in espeak-ng:

Description of how this pull request fixes the issue:

Upgrade to latest master of espeak-ng which addresses these issues.

Testing performed:

  • Ran NVDA with this version of eSpeak-ng.
  • espeak-ng now has tests which should cover these kinds of breaks in the future.

Known issues with pull request:

None.

Change log entry:

Upgrade to espeak-ng commit xxxx

@zstanecic

Copy link
Copy Markdown
Contributor

Hi michael,
Do we have any compilation errors in the espeak NG itself? i.e. some phonemedata cannot be generated properly?
if not, i suggest merging it to master for further testing of all slavic language branches...

@michaelDCurran

Copy link
Copy Markdown
Member Author

To @zstanecic, @nidza07 and k-kolev1985:
Please test the following try build of NVDA with latest espeak-ng master: https://ci.appveyor.com/api/buildjobs/e3c2cb43cjtd26pf/artifacts/output%2Fnvda_snapshot_try-latestEspeak-15686%2C0f0916a7.exe
Let me know if there are still regressions in eSpeak-ng from what is in NVDA 2018.2.

@zstanecic

Copy link
Copy Markdown
Contributor

Hi michael,
I can confirm, that all bugs are gone in this build of espeak NG.
I have tested bulgarian from the sample text of stoyan stoyanov, Gramatika na balgarskiot ezik
for macedonian i used a sample text from the website of macedonian radio television. i tested the simple characters, too!
the macedonian, as well as bulgarian, serbian and bosnian are now fixed.all palatalisations which were present are now gone.
@michaelDCurran
best,
Zvonimir

@zstanecic

Copy link
Copy Markdown
Contributor

btw, on new thing for macedonian, is added transliterated text reading
so all text romanized in the british manner, but written in macedonian will be read

@k-kolev1985

Copy link
Copy Markdown
Contributor

@michaelDCurran I've tested a little bit and I can confirm that the wrong pronunciations in bulgarian are fixed in the test build.

@LeonarddeR LeonarddeR left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

espeak-ng now has tests which should cover these kinds of breaks in the future.

Could we somehow run these tests within our test suite?

@michaelDCurran

michaelDCurran commented Jul 27, 2018 via email

Copy link
Copy Markdown
Member Author

@michaelDCurran michaelDCurran merged commit 00c8486 into master Jul 27, 2018
@nvaccessAuto nvaccessAuto added this to the 2018.3 milestone Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants