-
-
Notifications
You must be signed in to change notification settings - Fork 783
Restart confirmation dialog is confusing #6416
Copy link
Copy link
Closed
Labels
component/NVDA-GUIp4https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityquick fixz goodForNewDev (archived)
Milestone
Metadata
Metadata
Assignees
Labels
component/NVDA-GUIp4https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityquick fixz goodForNewDev (archived)
Type
Fields
Give feedbackNo fields configured for issues without a type.
While creating PR: #6415 to fix issue: #4561 I found that the restart confirmation dialog is confusing. My immediate expectation was that pressing cancel would make no changes and I would return to the general settings dialog. However the actual behaviour (as explained in the text) is that pressing cancel meant the general settings dialog would close, and the language change will be applied after the next restart of nvda. This dialog requires careful reading of the dialog in order to understand the outcomes.
The current text is:
With
okandcancelbuttons.Perhaps instead:
With
restart nowandrestart laterbuttonsOne issue with this is that for non-sighted users its not so clear what pressing enter will do, is this a valid concern here?