Fix up for "Split Turkish braille tables"#18758
Merged
Merged
Conversation
LeonarddeR
suggested changes
Aug 19, 2025
Member
|
@LeonarddeR I'm not sure I understand the issue. The diff looks correct and there's no merge conflicts |
seanbudd
approved these changes
Aug 19, 2025
Member
|
Can you please add a change log entry under "Changes" or "bug fixes" |
Collaborator
|
@SaschaCowley reverted #18726, I must have missed that somehow on my local copy of the repo. |
LeonarddeR
approved these changes
Aug 20, 2025
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
Apart from the missing changelog entry, this is fine with me. Thanks @OzancanKaratas
seanbudd
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the input/output mapping in the Turkish table in #18726.
@LeonarddeR, please review.
Link to issue number:
None
Summary of the issue:
The Turkish braille tables is incorrect in NVDA.
Description of user facing changes:
The user will see the Turkish 8 dot computer braille, Turkish grade 1 and Turkish grade 2.
Description of developer facing changes:
None
Description of development approach:
Add original Turkish grade 1, and rename tr.ctb as Turkish 8 dot computer braille.
Testing strategy:
Manual test using a braille display.
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary