MS Word with UIA: only fetch expandCollapseState for headings on Word version 16.0.18226 or higher.#18280
Conversation
… version 16.0.18226 or higher.
CyrilleB79
reviewed
Jun 18, 2025
Contributor
|
Change log is missing. Thanks. |
Co-authored-by: Cyrille Bougot <cyrille.bougot2@laposte.net>
seanbudd
reviewed
Jun 18, 2025
seanbudd
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18279
Summary of the issue:
PR #17499 added support for reporting if a heading is collapsed in MS word.
However, this crashes some versions of MS Word before this feature was supported.
For example, MS word version16.0.17932.20396 supports custom attribute values, but crashes if given this specific expandCollapseState constant.
NVDA should limit fetching this data to when it was officially supported in MS Word.
Description of user facing changes:
Microsoft Word 2024 will no longer crash when NVDA tries to fetch the collapsed state of headings.
Description of developer facing changes:
Description of development approach:
Limit fetching of expandcollapseState to MS Word 16.0.18226 and higher.
Testing strategy:
Known issues with pull request:
Code Review Checklist:
@coderabbitai summary