Move braille table definitions to its own file#18194
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Related to #11298
Summary of the issue:
Adding new liblouis tables is a manual process for every update. Furthermore, there are tables that are simply missing as they were never added. The display names we use also diverge from the liblouis metadata, which is from a later date.
Description of user facing changes
None
Description of development approach
This pr is the first in a series that will aid in table metadata/addition automation. It moves the add statements for all the tables to a separate file. This file can/should eventually be (re)generated by automation or a script.
Testing strategy:
Tested that tables still load.
Known issues with pull request:
I hope moving the several translatable strings won't mark everything fuzzy on crowdin/in the po files.
Code Review Checklist:
@coderabbitai summary