Updated NSIS to 3.11#18027
Merged
Merged
Conversation
See test results for failed build of commit 4ba162db4c |
# Conflicts: # user_docs/en/changes.md
SaschaCowley
previously requested changes
May 30, 2025
SaschaCowley
left a comment
Member
There was a problem hiding this comment.
Please update the NSIS submodule to point to the merge commit (i.e. nvaccess/NSIS-build@f8571bbe)
seanbudd
reviewed
Jun 2, 2025
seanbudd
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
nvaccess/NSIS-build#5
Summary of the issue:
Upgrade NSIS from 3.10 to 3.11.
Here are the Release Notes
Description of user facing changes
none
Description of development approach
Updated the NVDA/include/NSIS submodule
Testing strategy:
The scons launcher version=test1 command has been used to locally test the build of the installation package file, and testing in the CI environment is required.
Known issues with pull request:
none
Code Review Checklist:
@coderabbitai summary