-
-
Notifications
You must be signed in to change notification settings - Fork 767
Fix up pyright on pre-commit CI #17794
Copy link
Copy link
Labels
audience/nvda-devPR or issue is relevant to NVDA / Add-on developersPR or issue is relevant to NVDA / Add-on developersbugp3https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Milestone
Description
Metadata
Metadata
Assignees
Labels
audience/nvda-devPR or issue is relevant to NVDA / Add-on developersPR or issue is relevant to NVDA / Add-on developersbugp3https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Related issues, PRs or discussions
Fixup #17744
What is the current state of the codebase?
pyright runs on pre-commit locally, but is not triggered on the CI.
I think it's due to the names having conflict between the CI and local script.
Why are changes required?
As of #17745 , lint checks are no longer run on appveyor. this means that pyright is not running in CI at all.
What technical changes are required?
Ensure the pre-commit CI runs pyright.
If that's not possible, use an independent github action.
Are the proposed technical changes API breaking?
No
Are there potential risks or issues with the proposed implementation?
No