Skip to content

Remove lint from AppVeyor#17745

Merged
SaschaCowley merged 2 commits intomasterfrom
remLintAppVeyor
Mar 6, 2025
Merged

Remove lint from AppVeyor#17745
SaschaCowley merged 2 commits intomasterfrom
remLintAppVeyor

Conversation

@seanbudd
Copy link
Copy Markdown
Member

@seanbudd seanbudd commented Feb 26, 2025

Link to issue number:

None

Summary of the issue:

Since #16751, linting has been checked via pre-commit.ci rather than AppVeyor.
As a result the lint check in AppVeyor is redundant and adds unnecessary noise and time to the AppVeyor build.

Description of user facing changes

None

Description of development approach

Remove linting from AppVeyor.

Testing strategy:

Automated CI

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@seanbudd seanbudd requested a review from a team as a code owner February 26, 2025 04:18
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Mar 4, 2025
@SaschaCowley SaschaCowley merged commit 907ed77 into master Mar 6, 2025
3 checks passed
@SaschaCowley SaschaCowley deleted the remLintAppVeyor branch March 6, 2025 23:41
@github-actions github-actions bot added this to the 2025.1 milestone Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants