Remove legacy add-ons manager#15834
Merged
Merged
Conversation
michaelDCurran
approved these changes
Nov 27, 2023
Summary of the issue: Some dialogs could be moved to tidy up the add-on store work. These are part of the private API so moving them doesn't affect add-on authors. Remaining changes to integrate relevant code in addonHandler and addonGui to addonStore and addonStoreGui would require deprecations or API breaking changes. Description of development approach 2 dialogs moved to tidy up add-on store work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of development approach
Removes legacy add-ons manager as it is no longer used in NVDA, as it has been replaced by the add-on store.
No other code was identified that is no longer still used by the Add-on Store.
Known issues with pull request:
There is still code remaining that could be moved and simplified, however nothing that can be easily removed.
Code Review Checklist: