Skip to content

Move private message dialogs into addonStoreGui#15835

Merged
seanbudd merged 1 commit into
removeAddonsDialogfrom
moveAddonDialogCode
Nov 27, 2023
Merged

Move private message dialogs into addonStoreGui#15835
seanbudd merged 1 commit into
removeAddonsDialogfrom
moveAddonDialogCode

Conversation

@seanbudd

@seanbudd seanbudd commented Nov 27, 2023

Copy link
Copy Markdown
Member

Summary of the issue:

Some dialogs could be moved to tidy up the add-on store work.
These are part of the private API so moving them doesn't affect add-on authors.
Remaining changes to integrate relevant code in addonHandler and addonGui to addonStore and addonStoreGui would require deprecations or API breaking changes.

Description of development approach

2 dialogs moved to tidy up add-on store work.

Testing strategy:

Smoke test installing an add-on

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner November 27, 2023 05:15
@seanbudd seanbudd requested review from michaelDCurran and removed request for a team November 27, 2023 05:15
@seanbudd seanbudd merged commit dac9e17 into removeAddonsDialog Nov 27, 2023
@seanbudd seanbudd deleted the moveAddonDialogCode branch November 27, 2023 06:40
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants