Update Liblouis to 3.27.0#15435
Merged
Merged
Conversation
LeonarddeR
reviewed
Sep 13, 2023
| addTable("ro-g0.utb", _("Romanian 6 dot")) | ||
| # Translators: The name of a braille table displayed in the | ||
| # braille settings dialog. | ||
| addTable("ro.ctb", _("Romanian")) |
Collaborator
There was a problem hiding this comment.
Should this one be renamed in the GUI?
Collaborator
There was a problem hiding this comment.
Having a 6 dot and a nothing is a bit confusing.
Contributor
Author
There was a problem hiding this comment.
Hmmm, how about Romanian (legacy)?
Member
There was a problem hiding this comment.
Perhaps it's worth asking our romanian translators: https://github.com/nvaccess/mrconfig/blob/master/scripts/addressData.py#L358
Member
There was a problem hiding this comment.
Have we heard anything back yet?
Member
There was a problem hiding this comment.
I'm assuming we haven't heard anything back yet. In absence of a response, lets merge and fix the strings later if required?
Contributor
Author
There was a problem hiding this comment.
No response yet, sounds reasonable to me
seanbudd
approved these changes
Oct 3, 2023
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
Oct 12, 2023
Link to issue number: Fix-up of #15435 Description of how this pull request fixes the issue: Add @codeofdusk attribution for 2024.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Liblouis 3.27.0 has been released.
Description of how this pull request fixes the issue:
Update Liblouis to 3.27.0, including new Braille tables.
Testing strategy:
Verified that Braille functions without errors and that new tables are selectable.
Known issues with pull request:
None known
Change log entries:
== Changes ==
Code Review Checklist: