Skip to content

Add @codeofdusk attribution for 2024.1#15608

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
codeofdusk:fix-attributions-2024-1
Oct 12, 2023
Merged

Add @codeofdusk attribution for 2024.1#15608
seanbudd merged 2 commits into
nvaccess:masterfrom
codeofdusk:fix-attributions-2024-1

Conversation

@codeofdusk

@codeofdusk codeofdusk commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

Link to issue number:

Fix-up of #15435

Description of how this pull request fixes the issue:

Add @codeofdusk attribution for 2024.1

Testing strategy:

N/A

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@codeofdusk codeofdusk requested a review from a team as a code owner October 12, 2023 02:34
@codeofdusk codeofdusk requested a review from seanbudd October 12, 2023 02:34
@seanbudd

seanbudd commented Oct 12, 2023

Copy link
Copy Markdown
Member

Please do not make accreditations on behalf of other authors, it is up to them if they want to have their profile linked.

@codeofdusk

Copy link
Copy Markdown
Contributor Author

This PR includes contributions by me. How do I opt into accreditation?

@seanbudd

seanbudd commented Oct 12, 2023

Copy link
Copy Markdown
Member

You can remove the other accreditations and we can merge this.
Also please update the PR description

@seanbudd seanbudd changed the title Add attributions for 2024.1 (1 of 2) Add @codeofdusk attributions for 2024.1 Oct 12, 2023
@codeofdusk

Copy link
Copy Markdown
Contributor Author

OK. In case they want to add attributions, CCing @alexmoon, @CyrilleB79, @dmitrii-drobotov, @LeonarddeR, @michaelweghorn.

@seanbudd seanbudd changed the title Add @codeofdusk attributions for 2024.1 Add @codeofdusk attribution for 2024.1 Oct 12, 2023
@seanbudd seanbudd merged commit b8f45d9 into nvaccess:master Oct 12, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants