Skip to content

Added Simplified Chinese Braille table 'Chinese (China, Mandarin) Current Braille System (no tones)'#14138

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
cary-rowen:ChineseBraille_zh-chn
Sep 14, 2022
Merged

Added Simplified Chinese Braille table 'Chinese (China, Mandarin) Current Braille System (no tones)'#14138
seanbudd merged 4 commits into
nvaccess:masterfrom
cary-rowen:ChineseBraille_zh-chn

Conversation

@cary-rowen

@cary-rowen cary-rowen commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

zh-chn.ctb is a variant of the Chinese Current Braille System(zhcn-g1.ctb), which omits tones and allows for more braille content to be displayed for small braille displays.
In the nvda Chinese community, some people hope that this braille table can also be a candidate.
But there is no way to do this without manually renaming the table to replace the existing table.
So, I added it to braille settings dialog.

Description of user facing changes

Added Simplified Chinese Braille table 'Chinese(Current Braille System (no tones)'

Description of development approach

Add the definition of the table in brailleTables.py.

Testing strategy:

Manual testing.

Known issues with pull request:

None

Change log entries:

Changes

- Added new braille table: Chinese (China, Mandarin) Current Braille System (no tones) (#14138)

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@cary-rowen cary-rowen requested a review from a team as a code owner September 13, 2022 06:01
@cary-rowen cary-rowen requested a review from seanbudd September 13, 2022 06:01
Comment thread source/brailleTables.py Outdated
@cary-rowen

Copy link
Copy Markdown
Contributor Author

@seanbudd
OK, I'm done, and also added translator notes for the new braille table zhcn-cbs.

Comment thread source/brailleTables.py
Comment thread source/brailleTables.py
@seanbudd seanbudd changed the title Added Simplified Chinese Braille table 'Chinese(Current Braille System (no tones)' Added Simplified Chinese Braille table 'Chinese (China, Mandarin) Current Braille System (no tones)' Sep 13, 2022

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cary-rowen

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit cb4e06e144

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit cb4e06e144

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 8a26449582

@seanbudd seanbudd merged commit 26439b1 into nvaccess:master Sep 14, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.4 milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants