Update CLDR to version 39.0 by OzancanKaratas · Pull Request #12314 · nvaccess/nvda

Hi @OzancanKaratas, please fill in the full PR template in the future. The more background information you can provide the easier it is for us to review. I have updated this for you.

This change does not build, I'm going to convert this to a draft. The error can be found via the appveyor console log, I'll paste it here:

Compiling gettext template source\locale\my\LC_MESSAGES\nvda.po
Generating source\locale\nb_NO\cldr.dic
scons: *** [source\locale\nb_NO\cldr.dic] AssertionError : cldrDict is empty
Traceback (most recent call last):
  File "C:\projects\nvda\.venv\lib\site-packages\SCons\Action.py", line 1280, in execute
    result = self.execfunction(target=target, source=rsources, env=env)
  File "C:\projects\nvda\cldrDict_sconscript", line 40, in <lambda>
    lambda target,source,env: createCLDRAnnotationsDict([src.path for src in source], target[0].path),
  File "C:\projects\nvda\cldrDict_sconscript", line 29, in createCLDRAnnotationsDict
    assert cldrDict, "cldrDict is empty"
AssertionError: cldrDict is empty
scons: building terminated because of errors.
Deactivating NVDA Python virtual environment
Command exited with code 2

feerrenrut

Please ensure this change builds before converting back from draft.

AppVeyorBot · 2021-04-21T07:51:34Z

Build (for testing PR)

See test results for failed build of commit 964dc8b17f

CyrilleB79 · 2021-04-21T19:37:32Z

Does this PR fix #11963?

If yes, please add a reference to this issue in the change log.
If no, where does the issue come from?
- If from NVDA could it be fixed in this PR also?
- If from CLDR, is there an issue opened agains CLDR?

OzancanKaratas · 2021-04-21T19:51:51Z

Does this PR fix #11963?

I am not sure. Please test this pull request. However, this problem is not caused by CLDR, but by missing translations of the languages.

CyrilleB79 · 2021-04-22T22:28:56Z

Does this PR fix #11963?

I am not sure. Please test this pull request. However, this problem is not caused by CLDR, but by missing translations of the languages.

I am not convinced that the issue comes from missing translations. Please see #11963 (comment) and comment there since it is a better place to continue this discussion in any case.

AppVeyorBot · 2021-05-01T00:55:38Z

Build (for testing PR)

See test results for failed build of commit 0b7fc8d2cc

AppVeyorBot · 2021-05-03T17:18:42Z

Build (for testing PR)

See test results for failed build of commit 1b73b62eeb

AppVeyorBot · 2021-05-03T17:46:03Z

Build (for testing PR)

See test results for failed build of commit 2831fa0b6a

commit 86fe20f Author: Julien Cochuyt <JulienCochuyt@users.noreply.github.com> Date: Tue May 4 03:00:30 2021 +0200 Elements List: Don't remove the label of a filled spin button input field (#12317) (#12318) In browse mode documents, when a spin button input field is filled with a value, its label goes missing from the Elements List dialog. Description of how this pull request fixes the issue: Remove the role ROLE_SPINBUTTON from the set of exceptions for which the content replaces the label.

feerrenrut · 2021-05-07T07:13:40Z

@LeonarddeR Would you mind reviewing this? I'm not very sure what to look for with a CLDR change, could you comment on what you would test / check for so myself and @seanbudd can be better equipped to handle these PRs in the future? Perhaps we should add a readme for this at include/cldr.md

LeonarddeR

Looks good to me. Thanks @OzancanKaratas

codeofdusk · 2021-05-13T02:52:28Z

Do you plan to merge this in time for 2021.1?

seanbudd

I think we can merge this and create an issue for "create a readme at include/cldr.md" which requires information on updating CLDR and anything else relevant? @feerrenrut

seanbudd · 2021-05-13T02:58:35Z

Should we have more information in the changelog? It seems like more languages are supported now.

feerrenrut · 2021-05-13T09:24:24Z

I don't feel confident to make a call on this PR. It isn't clear if this specifically fixes issues, and whether it introduces new ones.
We can merge it and see who shouts, but it would be nice if this was a little more targeted.

OzancanKaratas · 2021-05-16T14:52:52Z

@feerrenrut, I think this pull request should be merged. For users who are experiencing problems due to missing translations in the NVDA and CLDR repository, we should not ignore those who have no problems.

michaelDCurran · 2021-05-16T23:13:09Z

I will merge this now, as it upgrades to cldr 39.0 and enables several new languages previously unavailable. However, to be very clear, this pr does not fix #11963 - This can only be done by switching to the cldr-staging repository and using the generated production data. I'll submit a pr for this once this one is merged.

Enables several new languages.

Update CLDR to version 39.0

bf4d3ae

OzancanKaratas requested a review from a team as a code owner April 20, 2021 16:00

feerrenrut suggested changes Apr 21, 2021

View reviewed changes

feerrenrut marked this pull request as draft April 21, 2021 07:41

Fix blank nb_NO

bdb44ce

OzancanKaratas marked this pull request as ready for review April 21, 2021 17:32

OzancanKaratas requested a review from feerrenrut April 21, 2021 17:32

lukaszgo1 reviewed Apr 21, 2021

View reviewed changes

Comment thread cldrDict_sconscript

OzancanKaratas added 2 commits April 22, 2021 16:22

Fix for Norvegian locale

06ad1ea

Merge branch 'master' into cldr39

109a55d

OzancanKaratas added 5 commits April 27, 2021 18:26

Merge remote-tracking branch 'remotes/origin/master' into cldr39

6859962

Merge remote-tracking branch 'remotes/origin/master' into cldr39

cf0e573

Merge remote-tracking branch 'remotes/origin/master' into cldr39

f9dfb94

Merge remote-tracking branch 'remotes/origin/master' into cldr39

2e4b579

Rebuild Turkish and Chinese

931b266

OzancanKaratas added 3 commits May 1, 2021 04:11

Revert rebuilds

c7e5c1e

Merge branch 'master' into cldr39

bc73cc4

Update locales

834eaff

Revision

34a5877

Remove failed languages

fada272

OzancanKaratas added 3 commits May 4, 2021 18:59

Merge remote-tracking branch 'remotes/origin/master' into cldr39

5564eba

Merge branch 'master' into cldr39

4e52034

seanbudd reviewed May 5, 2021

View reviewed changes

Comment thread cldrDict_sconscript Outdated

Apply suggestion

6976ee3

OzancanKaratas requested a review from seanbudd May 6, 2021 00:40

Ready for review

f300829

feerrenrut requested a review from LeonarddeR May 7, 2021 07:11

LeonarddeR approved these changes May 7, 2021

View reviewed changes

OzancanKaratas added 3 commits May 7, 2021 17:42

Merge remote-tracking branch 'remotes/origin/master' into cldr39

5d83838

Merge remote-tracking branch 'remotes/origin/master' into cldr39

2891ffe

Merge remote-tracking branch 'remotes/origin/master' into cldr39

e320b5e

seanbudd approved these changes May 13, 2021

View reviewed changes

OzancanKaratas added 2 commits May 13, 2021 17:10

Merge remote-tracking branch 'remotes/origin/master' into cldr39

2762366

Merge remote-tracking branch 'remotes/origin/master' into cldr39

5871cfb

michaelDCurran merged commit 9390d02 into nvaccess:master May 16, 2021

nvaccessAuto added this to the 2021.1 milestone May 16, 2021

OzancanKaratas deleted the cldr39 branch May 16, 2021 23:30

seanbudd pushed a commit that referenced this pull request May 17, 2021

Update CLDR to version 39.0 (#12314)

a54e564

Enables several new languages.

OzancanKaratas mentioned this pull request Dec 2, 2021

Accepting new CLDR updates #13123

Closed

Uh oh!

Conversation

OzancanKaratas commented Apr 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the issue:

Description of how this pull request fixes the issue:

Testing strategy:

Known issues with pull request:

Change log entries:

Code Review Checklist:

Uh oh!

OzancanKaratas commented Apr 20, 2021

Uh oh!

AppVeyorBot commented Apr 20, 2021

Uh oh!

feerrenrut commented Apr 21, 2021

Uh oh!

feerrenrut left a comment

Choose a reason for hiding this comment

Uh oh!

AppVeyorBot commented Apr 21, 2021

Uh oh!

Uh oh!

CyrilleB79 commented Apr 21, 2021

Uh oh!

OzancanKaratas commented Apr 21, 2021

Uh oh!

CyrilleB79 commented Apr 22, 2021

Uh oh!

AppVeyorBot commented May 1, 2021

Uh oh!

AppVeyorBot commented May 3, 2021

Uh oh!

AppVeyorBot commented May 3, 2021

Uh oh!

Uh oh!

feerrenrut commented May 7, 2021

Uh oh!

LeonarddeR left a comment

Choose a reason for hiding this comment

Uh oh!

codeofdusk commented May 13, 2021

Uh oh!

seanbudd left a comment

Choose a reason for hiding this comment

Uh oh!

seanbudd commented May 13, 2021

Uh oh!

feerrenrut commented May 13, 2021

Uh oh!

OzancanKaratas commented May 16, 2021

Uh oh!

michaelDCurran commented May 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

OzancanKaratas commented Apr 20, 2021 •

edited

Loading