Skip to content

Elements List: Don't remove the label of a filled spin button input field (#12317)#12318

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
accessolutions:i12317-spinButtonLabelInElementsList
May 4, 2021
Merged

Elements List: Don't remove the label of a filled spin button input field (#12317)#12318
seanbudd merged 1 commit into
nvaccess:masterfrom
accessolutions:i12317-spinButtonLabelInElementsList

Conversation

@JulienCochuyt

@JulienCochuyt JulienCochuyt commented Apr 21, 2021

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #12317
Fix-up of PR #6131

Summary of the issue:

In browse mode documents, when a spin button input field is filled with a value, its label goes missing from the Elements List dialog.

Description of how this pull request fixes the issue:

Remove the role ROLE_SPINBUTTON from the set of exceptions for which the content replaces the label.

Testing strategy:

In Firefox / Chrome / Edge Chromium:
Ensure the label is present with empty spin button input field.
Ensure the label is present with non-empty spin button input field.

Known issues with pull request:

There might be other roles for which both the label and content are desirable.
For the record, remaining exceptions as of this PR are:

  • ROLE_BUTTON
  • ROLE_DROPDOWNBUTTON
  • ROLE_TOGGLEBUTTON
  • ROLE_SPLITBUTTON
  • ROLE_MENUBUTTON
  • ROLE_DROPDOWNBUTTONGRID
  • ROLE_TREEVIEWBUTTON

Change log entries:

I do not think this small fix deserves a change log entry.

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

@JulienCochuyt JulienCochuyt requested a review from a team as a code owner April 21, 2021 11:23
@JulienCochuyt JulienCochuyt requested a review from seanbudd April 21, 2021 11:23

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @JulienCochuyt

@seanbudd seanbudd merged commit 86fe20f into nvaccess:master May 4, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone May 4, 2021
@JulienCochuyt JulienCochuyt deleted the i12317-spinButtonLabelInElementsList branch May 4, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[html5 input type="number"] Label missing from the Elements List when the field is not empty

3 participants