Fix up of 11738: Force UIA for Outlook messages list even though it doesn't support UIA natively#12241
Merged
michaelDCurran merged 3 commits intoApr 20, 2021
Conversation
Contributor
Author
|
@michaelDCurran While I haven't gotten confirmation from any of the people who have reported the problem in the first place this pr certainly brings accessibility of the Outlook 2010 message list back to the pre 2020.4 state on my machine. Could you please take a look? |
michaelDCurran
approved these changes
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None. Reported here and here on users list.
Summary of the issue:
PR #11738 made it impossible to use UIA for controls which doesn't report as native UIA. This decreased accessibility of Outlook's messages list in some versions of Outlook (certainly for 2010 and possibly for 2013) which reports as non native UIA.
Description of how this pull request fixes the issue:
Similar to the fix in #11828 for these controls the fact that they're non native UIA is ignored.
Testing strategy:
Ensured that list of messages in Outlook 2010 behaves the same way as it did in NVDA 2020.3
I'll post the link to the build from this pr to the both threads mentioned above and ask users there for confirmation.
Known issues with pull request:
None known.
Change log entry:
Section: Bug fixes
Code Review Checklist:
This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x:
[ ]becomes[x].You can also check the checkboxes after the PR is created.