Remove backwards compat aliases from PR 10593#12195
Merged
Merged
Conversation
Contributor
Author
|
cc @seanbudd |
9e1f1fb to
f80bffb
Compare
seanbudd
approved these changes
Mar 22, 2021
See test results for failed build of commit 359295caaf |
This was referenced Mar 25, 2021
seanbudd
pushed a commit
that referenced
this pull request
Mar 30, 2021
…uses` which has been used for say all. (#12228) Fixes #12225 PR #12195 removed speech.speakWithoutPauses which was an alias for speech._speakWithoutPauses. While all usages of speech.speakWithoutPauses were found and fixed it turned out than when cancelling speech during say all speech._speakWithoutPauses was cleared rather than instance of SpeakWithoutPauses used for say all. Now the instance of SpeechWithoutPauses which is used during say all is cleared. A function is added to sayAllHandler which creates it first if necessary, and ensures that the single instance is being used for say all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None, Removes code provided for backwards compatibility in PR #10593
Summary of the issue:
PR #10593 introduced
speech.speakWithoutPausesas an alias forspeech._speakWithoutPauses.speakWithoutPausesandspeech.re_last_pauseas an alias forspeech._speakWithoutPauses.re_last_pausefor backwards compatibility. Since 2021.1 is going to be backwards compatibility breaking release it makes sense to remove these.Description of how this pull request fixes the issue:
These aliases are removed and their usages are replaces with
speech.SpeechWithoutPauses(speakFunc=speech.speak).speakWithoutPausesandspeech.SpeechWithoutPauses.re_last_pauserespectively.Testing strategy:
Known issues with pull request:
None known
Change log entry:
Changes for developers:
speech.speakWithoutPauseshas been removed - please usespeech.SpeechWithoutPauses(speakFunc=speech.speak).speakWithoutPausesinsteadspeech.re_last_pausehas been removed - please usespeech.SpeechWithoutPauses.re_last_pauseinstead.Code Review Checklist:
This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x:
[ ]becomes[x].You can also check the checkboxes after the PR is created.