Remove deprecated functions from the config module#11935
Merged
michaelDCurran merged 6 commits intoJan 21, 2021
Merged
Conversation
… introduced in nvaccess#10493 from the config module
LeonarddeR
previously approved these changes
Dec 14, 2020
michaelDCurran
approved these changes
Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None -removes functions marked as deprecated in #10493
Summary of the issue:
Development cycle for 2021.1 has begun! This release aims to remove deprecated functions from the source code and various such functions were located in the
configmodule.Description of how this pull request fixes the issue:
This PR removes:
config.hasUiAccessandconfig.execElevatedwhich were added to maintain backwards compatibility in Add a script to oopen NVDA config directory #10493config.getConfigDirswhich was deprecated some time ago, was supposed to be removed during 2019.3 dev cycle in PR Remove functionality marked as deprecated #9603 but was apparently missedconfig.canStartOnSecureScreenswhich is no longer useful as we do not support anything older than Win 7 and therefore every installed copy can start on secure screens.While at it I've also added some missing imports from typing to the config module.
Testing performed:
With git grep ensured that these functions are not used anywhere in the source code.
Known issues with pull request:
Change log entry:
Section: changes for developers:
The following functions are removed from the config module:
canStartOnSecureScreens- useconfig.isInstalledCopyinstead.hasUiAccessandexecElevated- use them from thesystemUtilsmodule.getConfigDirs- useglobalVars.appArgs.configPathinstead