Add original Seika Notetaker driver by moyanming · Pull Request #11514 · nvaccess/nvda

moyanming · 2020-08-20T12:57:54Z

Link to issue number:

Summary of the issue:

Seika Notetaker drivers do not exist in NVDA

The Seika Notetaker Braille display is not the same as the Seika Braille display.
Seika Notetaker has 8 dots, Braille keyboard and other function keys/buttons

Description of how this pull request fixes the issue:

Adds the driver

Testing performed:

Manual testing from those with the device

Known issues with pull request:

None

Change log entry:

New features

Support for the Seika Notetaker braille display from Nippon Telesoft.

Code Review Checklist:

Pull Request description is up to date.
Unit tests.
System (end to end) tests.
Manual testing.
User Documentation.
Change log entry.
Context sensitive help for GUI changes.
UX of all users considered:
- Speech
- Braille
- Low Vision
- Different web browsers

AppVeyorBot · 2020-08-20T13:07:21Z

PR introduces Flake8 errors
Build (for testing PR)

See test results for failed build of commit f62982f720

LeonarddeR · 2020-08-22T06:45:27Z

@moyanming Are you the author of this driver or did you copy it from somewhere else?

moyanming · 2020-08-22T09:29:43Z

@moyanming Are you the author of this driver or did you copy it from somewhere else?

Hi @LeonarddeR , we are the manufacturer of the Seika Notetaker Braille display and @Ulf-Beckmann is our partner. We define the transfer protocol and develop the add-on and then test the driver makes all work fine. BTW, @Ulf-Beckmann not use GitHub frequently.

LeonarddeR · 2020-08-22T10:31:45Z

Thanks for clarifying.

First of all, I think it is necessary that the linting errors are fixed. Please see the linting your changes section in the repository ReadMe.

moyanming · 2020-08-22T12:38:40Z

Thanks for clarifying.

First of all, I think it is necessary that the linting errors are fixed. Please see the linting your changes section in the repository ReadMe.

Thanks for the reminder. I will fix those errors as soon as possible.

LeonarddeR · 2020-08-22T12:55:44Z

It might be best to address the change requests in #10961 first.

AppVeyorBot · 2020-11-19T09:21:20Z

Build (for testing PR)
PR introduces Flake8 errors

See test results for failed build of commit 12f966029a

AppVeyorBot · 2020-11-19T09:48:09Z

PR introduces Flake8 errors
Build (for testing PR)

See test results for failed build of commit 74dd0ece52

lukaszgo1

Please pay attention to places where you've left code which is no longer used but rather than removed is merely commented out (I haven't commented on all of them)

AppVeyorBot · 2021-03-04T08:31:26Z

PR introduces Flake8 errors
Build (for testing PR)

See test results for failed build of commit 82cd5eafc9

moyanming · 2021-04-19T06:36:04Z

Hi,
Any new information/request about this PR?
Best Regards

cary-rowen · 2021-04-19T06:51:48Z

I will test the build version of this PR later today.

Thanks

MichelSuch · 2021-04-19T07:00:48Z

I missed the link of the build, could you please give it so I can test with my old Seika 2?

moyanming · 2021-04-19T12:57:49Z

Hi, I missed the link of the build, could you please give it so I can test with my old Seika 2?

Hi @MichelSuch ,
Since your device is Seika 2, please download this PR build for a test, you should select the Seika v3/5/80 item within the NVDA.

moyanming · 2021-04-19T13:01:08Z

I will test the build version of this PR later today.

Thanks

Thanks for the test.

We have tested this PR build with the mini16/24/v6 are worked well. I mean anyone can review this PR for the integration to the main branch?
Best Regards

cary-rowen · 2021-04-21T05:35:55Z

Sorry, I am late,
I tested the build version of this PR with a Mini24 device and it worked well, so I think the PR can be merged.
@LeonarddeR
@moyanming

zstanecic · 2021-04-21T05:59:11Z

you are not late. I’ve also received the confirmation that the driver works.

cary-rowen · 2021-05-04T03:04:12Z

Is there anything else to be done for this PR? Is it possible to merge?
thanks.
@seanbudd @feerrenrut

JulienCochuyt · 2021-05-04T06:47:59Z

@moyanming, could you please confirm this driver is also expected to work with the Seika v7 computer? Both when using the v7 as an external display and when installing NVDA on the Windows embedded in it?

moyanming · 2021-05-06T07:36:39Z

@moyanming, could you please confirm this driver is also expected to work with the Seika v7 computer? Both when using the v7 as an external display and when installing NVDA on the Windows embedded in it?

Hi @JulienCochuyt
Yes, this PR work with Seika v7, both when using the v7 in mode 2 (external Braille display) and mode 3 (self-running Windows 10 OS with NVDA).

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

seanbudd

LGTM otherwise

seanbudd

Thanks, this is much clearer now

moyanming · 2021-06-11T09:26:31Z

Hi, @feerrenrut
I have tested this PR build, but I got the "Could not load the seikantk" after selecting the "Seika Notetaker" Braille item in this version of NVDA.
I also tested the NVDA 2021.1beta2 and this version can't load the Seika notetaker too.

BTW, this PR build works fine.

Is there some issue within the component of the beta version?

Best Regards

seanbudd · 2021-06-15T05:01:30Z

Hi @moyanming,

Could you provide a log file, with debug logging enabled, of what happens when you do the following:

select the "Seika Notetaker" Braille item in NVDA 2021.1beta2 (or newer), with the device connected

I'm going to investigate for any obvious causes but this will aid the fix greatly.

moyanming · 2021-06-21T08:45:10Z

Hi @moyanming,

Could you provide a log file, with debug logging enabled, of what happens when you do the following:

select the "Seika Notetaker" Braille item in NVDA 2021.1beta2 (or newer), with the device connected

I'm going to investigate for any obvious causes but this will aid the fix greatly.

Hi, @seanbudd
Please find the attached :
nvda.log
It seems that the "hidvidpid" is not matched.

I have tried two times and got the same error.
Here is the log snippet:
INFO - brailleDisplayDrivers.seikantk.BrailleDisplayDriver.__init__ (16:11:53.151) - MainThread (5312): Seika Notetaker braille driver path: \\?\hid#vid_10c4&pid_ea80#6&21f75a11&0&0000#{4d1e55b2-f16f-11cf-88cb-001111000030} ERROR - braille.BrailleHandler.setDisplayByName (16:11:56.285) - MainThread (5312): Error initializing display driver seikantk for kwargs {} Traceback (most recent call last): File "braille.pyc", line 1742, in setDisplayByName File "brailleDisplayDrivers\seikantk.pyc", line 132, in __init__ RuntimeError: No MINI-SEIKA display found, no response INFO - braille.BrailleHandler.setDisplayByName (16:11:56.317) - MainThread (5312): Loaded braille display driver noBraille, current display has 0 cells.

Any ideas?

seanbudd · 2021-06-22T00:44:46Z

It looks "hidvidpid" is matched, as we make it to the stage where we check self.numCells == 0, which is throwing the error. It looks like the device info isn't being stored via the SEIKA_INFO command. Without a device in hand, all we can do is add logging and create a build for you or someone with the device to check. Could you open a new issue?

moyanming · 2021-06-22T07:08:09Z

Hi, @seanbudd
The function "_onReceive" changes a lot compared to my commit version.
There need improvement and a new issue should be opened.
But I recommend this PR #11514 should merge even there is an issue.
This issue should be fixed in the next release version.

Add original Seika Notetaker driver by using Python 3.

192585b

moyanming mentioned this pull request Aug 20, 2020

Add supports Seika Notetaker Braille display #10991

Closed

fixed flake8 errors.

d498c77

fixed flake8.

af08d2f

fix flake8.

d34b1df

lukaszgo1 suggested changes Nov 20, 2020

View reviewed changes

fix requests.

e24b3ec

lukaszgo1 reviewed Feb 12, 2021

View reviewed changes

Comment thread source/brailleDisplayDrivers/seikantk.py Outdated

delete the explicit config setting.

344d3c2

fix Flake8 error.

84af837

moyanming mentioned this pull request Apr 2, 2021

Update seika braille driver for python 3 #10961

Merged

feerrenrut and others added 6 commits June 3, 2021 11:11

Apply review actions

79c2325

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

Apply review actions

9fd24c9

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

Apply review actions

0c69a1f

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

Apply review actions

9bdb7a7

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

Apply review actions

80c6a38

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

remove unused variable

ef1bf40

feerrenrut changed the base branch from master to beta June 3, 2021 03:24

seanbudd and others added 2 commits June 3, 2021 13:34

Merge branch 'beta' into seikaNotetakerPython3

c823763

Further review actions

67a590d

seanbudd previously approved these changes Jun 3, 2021

View reviewed changes

Comment thread source/brailleDisplayDrivers/seikantk.py Outdated

clarify comment

f3242e9

feerrenrut dismissed seanbudd’s stale review via f3242e9 June 3, 2021 09:25

seanbudd reviewed Jun 3, 2021

View reviewed changes

Comment thread source/brailleDisplayDrivers/seikantk.py Outdated

seanbudd and others added 2 commits June 3, 2021 19:43

Merge branch 'beta' into seikaNotetakerPython3

4f0c337

further clarification of comment

29173bf

seanbudd previously approved these changes Jun 4, 2021

View reviewed changes

seanbudd added 2 commits June 4, 2021 11:10

Merge branch 'beta' into seikaNotetakerPython3

dda8b3e

update changes

cc42266

seanbudd dismissed their stale review via cc42266 June 4, 2021 03:16

seanbudd approved these changes Jun 4, 2021

View reviewed changes

seanbudd merged commit 77ee534 into nvaccess:beta Jun 4, 2021

nvaccessAuto added this to the 2021.2 milestone Jun 4, 2021

seanbudd modified the milestones: 2021.2, 2021.1 Jun 4, 2021

seanbudd mentioned this pull request Jun 24, 2021

Fix how the Seika Notetaker Driver processes data #12581

Merged

8 tasks

Uh oh!

Conversation

moyanming commented Aug 20, 2020 • edited by seanbudd Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link to issue number:

Summary of the issue:

Description of how this pull request fixes the issue:

Testing performed:

Known issues with pull request:

Change log entry:

Code Review Checklist:

Uh oh!

AppVeyorBot commented Aug 20, 2020

Uh oh!

LeonarddeR commented Aug 22, 2020

Uh oh!

moyanming commented Aug 22, 2020

Uh oh!

LeonarddeR commented Aug 22, 2020

Uh oh!

moyanming commented Aug 22, 2020

Uh oh!

LeonarddeR commented Aug 22, 2020

Uh oh!

AppVeyorBot commented Nov 19, 2020

Uh oh!

AppVeyorBot commented Nov 19, 2020

Uh oh!

lukaszgo1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AppVeyorBot commented Mar 4, 2021

Uh oh!

moyanming commented Apr 19, 2021

Uh oh!

cary-rowen commented Apr 19, 2021

Uh oh!

MichelSuch commented Apr 19, 2021 via email • edited by feerrenrut Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moyanming commented Apr 19, 2021 • edited by feerrenrut Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moyanming commented Apr 19, 2021

Uh oh!

cary-rowen commented Apr 21, 2021

Uh oh!

zstanecic commented Apr 21, 2021 via email • edited by feerrenrut Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cary-rowen commented May 4, 2021

Uh oh!

JulienCochuyt commented May 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moyanming commented May 6, 2021

Uh oh!

seanbudd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

seanbudd left a comment

Choose a reason for hiding this comment

Uh oh!

moyanming commented Jun 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seanbudd commented Jun 15, 2021

Uh oh!

moyanming commented Aug 20, 2020 •

edited by seanbudd

Loading

MichelSuch commented Apr 19, 2021 via email •

edited by feerrenrut

Loading

moyanming commented Apr 19, 2021 •

edited by feerrenrut

Loading

zstanecic commented Apr 21, 2021 via email •

edited by feerrenrut

Loading

JulienCochuyt commented May 4, 2021 •

edited

Loading

moyanming commented Jun 11, 2021 •

edited

Loading