Add supports Seika Notetaker Braille display#10991
Conversation
See test results for failed build of commit 4bc424f232 |
|
hi@moyanming |
|
Hi @dingpengyu , |
See test results for failed build of commit e9616fe5e8 |
Fixed Flake8 errors.
See test results for failed build of commit 1f6ce516de |
|
@moyanming, the DLLs most likely belong to the |
|
Blocked pending feedback from @michaelDCurran |
|
What is the license for these 3 dlls? Is the source code available? Our policy these days is usually not to add device dlls to NVDA, preferring pure Python code, or at very least, public access to the source code, what ever the language. |
|
This looks like a new incarnation of #9479. I expressed my concern with this driver in #9479 (comment). Long story short, I agree with @michaelDCurran |
|
@moyanming could you please respond to the last two comments above? |
|
Looking at the properties for these dll's, they are "Copyright Silicon laboratories, Inc". We have no license to use and distribute them. Given there is no indication that the PR author is going to seek a license to use these files, unfortunately means I will have to close this PR. I'll also mark it as abandoned, we haven't heard from the author since April. I would like to welcome anyone interested to seek a license for the NVDA project to use these files. |
|
I'd rather see a native driver, avoiding the use of DLLs altogether.
|
|
Yes, I agree. |
Hi @Adriani90 , |
Add supports Seika Notetaker Braille display.
Add driver files by using the Seika Notetaker addon for NADA v3.3.
Link to issue number:
#9479
Summary of the issue:
Description of how this pull request fixes the issue:
Testing performed:
Known issues with pull request:
Change log entry:
Section: New features, Changes, Bug fixes
New features.