Update brlapi to 0.8#11065
Merged
Merged
Conversation
Contributor
|
@LeonarddeR While I no longer have the old ALVA which requires BRLTTY and therefore no BRLTTY is installed on my system, in the previous Alpha's it was possible to import brlapi anyway, and BRLTTY was present in the braille displays list whereas now it is not. Additionally there is no brlapi.dll in the NVDA folder anymore. Is this a change in brlapi bindings? |
Collaborator
Author
|
Ugh, you're correct. Interesting enough, I tested this with a try build and that all went fine. It's this try build. Let me investigate what went wrong here. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
With the migration to Python 3, we had to update our brlapi dependency to 0.7 to support the brltty braille display driver. However, there wasn't an upstream build of the brlapi python bindings, therefore we had to build them ourselves.
Description of how this pull request fixes the issue:
Thanks to @DaveMielke, BRLTTY 6.1 bundles a brlapi binding built against Python 3.7 we could use directly from upstream. Note that it is still bundled inside our misc-deps repository.
Testing performed:
Tested a try build with brlapi 0.8 against an installed build of brltty 6.1. I'm pretty sure however that this brlapi should still be able to work with older versions of brltty, may be @DaveMielke can give some info on that.
Known issues with pull request:
None
Change log entry: