Skip to content

Add a script to toggle the report of superscripts and subscripts#10985

Merged
feerrenrut merged 5 commits into
nvaccess:masterfrom
CyrilleB79:superscriptSubscript
Apr 16, 2020
Merged

Add a script to toggle the report of superscripts and subscripts#10985
feerrenrut merged 5 commits into
nvaccess:masterfrom
CyrilleB79:superscriptSubscript

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

Almost all items of the "Document formatting" setting panel have an associated script to toggle the feature. Since #10919 has been merged, it would be useful to have a script to toggle superscripts and subscripts reporting. For example the feature would be activated when reading a mathematical document with squared variables. But it should be deactivated when reading a normal document containing abbreviations such as 1st, 2nd, etc.

Description of how this pull request fixes the issue:

Add a script in global commands to toggle the reporting of superscripts and subscripts. This script has no default gesture assigned.

Testing performed:

  • Assigned a gesture to the script.
  • Open this page, and go to the demo output.
  • Toggle the superscripts and subscripts reading with the gesture and checked that superscripts were reported consequently when reading the following line:
    a2 + b2 = c2

Did not test with MS Word since there is a pending issue: #10979

Known issues with pull request:

This PR does not guarantee that all features of "Document formatting" setting panel has an associated script: cell border reporting is still missing. However there is already a PR for this (#10408)

Change log entry:

Section: New features

A script to toggle the report of subscripts and superscripts has been added.

or just modify the change log entry for #10919 to add this PR's information.

@CyrilleB79

Copy link
Copy Markdown
Contributor Author

@codeofdusk did you have any reason not to associate a dedicated script to superscripts/subscripts reporting toggle? I did not seen anything in #10919.

Cc @LeonarddeR:
Can you also have a look at this one? Thanks.

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 16faf14428

@feerrenrut feerrenrut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue to address, otherwise this looks fine

Comment thread source/globalCommands.py Outdated
Comment thread source/globalCommands.py Outdated
CyrilleB79 and others added 2 commits April 14, 2020 22:10
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 2aeef4ccdd

@CyrilleB79

Copy link
Copy Markdown
Contributor Author

@feerrenrut, I have addressed your feedback and suggestion. Thanks.

@feerrenrut feerrenrut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

@feerrenrut feerrenrut merged commit 827ec77 into nvaccess:master Apr 16, 2020
@nvaccessAuto nvaccessAuto added this to the 2020.1 milestone Apr 16, 2020
@feerrenrut feerrenrut modified the milestones: 2020.1, 2020.2 Apr 16, 2020
feerrenrut added a commit that referenced this pull request Apr 16, 2020
@codeofdusk

Copy link
Copy Markdown
Contributor

I think the existing changes entry should be modified to mention the script instead of adding to new features (the change itself is new to 2020.2).

@feerrenrut

Copy link
Copy Markdown
Contributor

I added a new entry, since there are now two new things you can do. Configure reporting, and toggle.

@codeofdusk

Copy link
Copy Markdown
Contributor

Maybe change the existing entry to something like:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants