Fix superscripts and subscripts reporting for MS Word (legacy).#10979
Merged
feerrenrut merged 3 commits intoApr 14, 2020
Conversation
See test results for failed build of commit 11e2f7e966 |
Contributor
Author
|
Compiled and tested successfully commit 045fff0 as described in the Test section of the initial description of this PR. |
Contributor
Author
|
Cc @codeofdusk, @LeonarddeR and @feerrenrut since you have participated or review #10919. |
LeonarddeR
approved these changes
Apr 11, 2020
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, though there are some long lines in this that could possibly be split.
Contributor
Author
|
@LeonarddeR are you talking about the .cpp file? I agree the code is not well readable in this file with long lines and missing spaces. There is no linting check for .cpp files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
With #10919, superscript and subscript are now reported separately from other attributes. However in MS Word legacy (no UIA), this works only if "Font attributes" is also checked in "Document formatting" setting panel. Checking only "Subscript and superscript" does not work in MS Word legacy support (no UIA).
Description of how this pull request fixes the issue:
This PR separates completely subscript and superscript handling with respect to attributes handling in winword.cpp
Testing performed:
Not yet. I have issue with my build environment on my machine. I will try an another machine when I have access to it or test with the build from appVeyor.
I leave this PR as draft in the meantime.
PlannedNow Completed tests on Word (legacy mode) (as per comment ):Check that bold and subscripts/superscripts announcements are honored when requested.
Known issues with pull request:
None
Change log entry:
None since #10919 is not yet in a stable release.