Skip to content

Update JAB to 17.0.9#1

Merged
seanbudd merged 1 commit into
masterfrom
v17
Nov 5, 2023
Merged

Update JAB to 17.0.9#1
seanbudd merged 1 commit into
masterfrom
v17

Conversation

@seanbudd

@seanbudd seanbudd commented Nov 2, 2023

Copy link
Copy Markdown
Member

Updated the dll file following the README steps.

Smoke tested with PyCharm.

If there are known smoke testing steps, these should be added to the README.

@seanbudd

seanbudd commented Nov 3, 2023

Copy link
Copy Markdown
Member Author

@mwhapples - would you be able to smoke test our update to JAB or suggest smoke testing steps?

Here is a build to test with:
https://ci.appveyor.com/api/buildjobs/9jkp295qfgi9mkuj/artifacts/output%2Fnvda_snapshot_try-JAB-17-29837%2Cfd1942a2.exe

@mwhapples

Copy link
Copy Markdown

I will give it testing today.

@mwhapples

Copy link
Copy Markdown

As an aside, are you aware that (java 21 is out and that is supposed to be LTS, so would it be better to go to (java 21 JAB?

@seanbudd

seanbudd commented Nov 3, 2023

Copy link
Copy Markdown
Member Author

Zulu isn't offering a 32bit build of 21 unfortunately, I'm not sure if 32bit support is fully dropped in that release or they just haven't made a build yet

@seanbudd

seanbudd commented Nov 3, 2023

Copy link
Copy Markdown
Member Author

I see 32bit was deprecated in 21, probably why they didn't create a build

https://openjdk.org/jeps/449

@mwhapples

Copy link
Copy Markdown

As my projects using Java are only targetted for 64-bit systems, I didn't notice that X86 32-bit was deprecated in 21. I have looked around and seems like all the OpenJDK builds no longer include 32-bit (eg. adoptium, Azul, Microsoft, Amazon corretto, etc).

@mwhapples

Copy link
Copy Markdown

Yesterday I tried the build and did not notice anything untoward, at least not compared with existing JAB support. However I was using it whilst working in PyCharm, so its more real world testing than methodical testing of different Java components.

@seanbudd

seanbudd commented Nov 5, 2023

Copy link
Copy Markdown
Member Author

Thanks for the testing, it is appreciated

@seanbudd seanbudd merged commit a275a29 into master Nov 5, 2023
@seanbudd seanbudd deleted the v17 branch November 5, 2023 22:55
seanbudd added a commit to nvaccess/nvda that referenced this pull request Nov 5, 2023
Incorporates changes from nvaccess/javaAccessBridge32-bin#1

Update JAB to v17.0.9 from v13.0.1

Followed steps in the NVDA JAB README
@akash07k

akash07k commented Nov 6, 2023

Copy link
Copy Markdown

@seanbudd Will it improve anything for the accessibility of existing java applications such as Android Studio?

@mwhapples

Copy link
Copy Markdown

There are some Java Access bugs I am fairly sure which will not be affected by this change, unfortunately they would require API changes to the Java Access Bridge or for NVDA to do something more intelligent with what it gets. One such example would be notification/announcing expanding/collapsing treeview items. This is not to say there won't be any improvements, but I doubt they are going to be anything major.

@mwhapples

Copy link
Copy Markdown

I will still give it some testing whilst using (java based applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants