Add readFeeds 13.0.0 (beta) to NVDA add-ons datastore#24
Merged
Conversation
Contributor
|
We haven't enabled auto merging yet. But we do plan to do so. |
github-actions Bot
pushed a commit
that referenced
this pull request
Jan 22, 2022
Commit message: Add readFeeds 13.0.0 (beta) to NVDA add-ons datastore (#24)
Contributor
Author
|
Then I"ll create PRs that should be merged. My intention was also to create some of them wit invalid last tested version like 9999. We can test this when automerging is enabled. As far as I know, the addon-datastore-validation don"t check for NVDA available versions. Another concern is if someone tryies to publish an existing add-on with the same id than an existing one and other publisher. For example, if I try to publish wintenApps with nvdaes as the publisher, or if I try to delete the existing wintenApps. Maybe automerging can be disabled until this is fixed. Anyway the automatic checks facilitate things a lot in comparison with the review process in addonFiles.
Enviado desde mi iPhone
… El 22 ene 2022, a las 9:23, Reef Turner ***@***.***> escribió:
We haven't enabled auto merging yet. But we do plan to do so.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
Contributor
|
Please go ahead and test any edge-cases you can think of now. Better if these don't get merged. We'll see if the automated checks pass. When we enable auto-merging it will only do so if the automated checks pass. |
Contributor
Author
|
Ok. I"ll try to send a PR to delete the merged wintenApps from @josephsl. Also, I"ll send a PR setting publisher to @josephsl even if the add-on is not published by him. Of course mods can be accepted and a same add-on can be published by different people. I think this cannot be avoided, but at least maybe better that publishers are automatically set in the json file from an issuer considering the GitHub user that sends an add-on. And maybe also good that an add-on cannot be automatically deleted by someone who is not the original publisher. If someone cannot delete an addon who previously has published, this can be removed by admins in some moment. To set the publisher automatically, maybe better starting with a procedure based on issues before enabling automerge. The source URL, license and canonical version,and download url, should be manually registered in the issue form. Then the add-on should be downloaded and the json file built from the binary, calculating sha256 and other fields from manifest, generating the .json file. Maybe better. To delete an add-on, the download url should suffice if the original publisher sends the issue. If someone needs help, this can be considered manually requesting this to admins.
Enviado desde mi iPhone
… El 24 ene 2022, a las 4:20, Reef Turner ***@***.***> escribió:
Please go ahead and test any edge-cases you can think of now. Better if these don't get merged. We'll see if the automated checks pass.
When we enable auto-merging it will only do so if the automated checks pass.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
seanbudd
pushed a commit
that referenced
this pull request
Mar 4, 2026
Found while reviewing nvaccess/nvda#15888 Issue NVDA API version json file does not cover all existing NVDA versions. These ones minor versions are missing: 2018.4.1 2019.1.1 2019.2.1 2019.3.1 I doubt any add-on is impacted by these missing minor versions. But for completeness and clarity, it's better to have them covered. Solution Fix the description of API 0.0.0 so that 2018.4.1 is covered Added API for 2019.1.1 and 2019.2.1 Fixed description of 2019.3 to include also 2019.3.1. No API is added for this version since it contains only new translations; it is worth noting that this version is not listed in NVDA's change log.
seanbudd
pushed a commit
that referenced
this pull request
Mar 17, 2026
Found while reviewing nvaccess/nvda#15888 Issue NVDA API version json file does not cover all existing NVDA versions. These ones minor versions are missing: 2018.4.1 2019.1.1 2019.2.1 2019.3.1 I doubt any add-on is impacted by these missing minor versions. But for completeness and clarity, it's better to have them covered. Solution Fix the description of API 0.0.0 so that 2018.4.1 is covered Added API for 2019.1.1 and 2019.2.1 Fixed description of 2019.3 to include also 2019.3.1. No API is added for this version since it contains only new translations; it is worth noting that this version is not listed in NVDA's change log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add-on sent mostly to test the store. Channel is beta and this test should pass, i.e., this PR should be automatically merged. Metadata has been validated locally.