WIP: feat: runtime config support for detectBrowserLanguage#2576
Closed
BobbieGoede wants to merge 7 commits intonuxt-modules:mainfrom
Closed
WIP: feat: runtime config support for detectBrowserLanguage#2576BobbieGoede wants to merge 7 commits intonuxt-modules:mainfrom
detectBrowserLanguage#2576BobbieGoede wants to merge 7 commits intonuxt-modules:mainfrom
Conversation
detectBrowserLanguagedetectBrowserLanguage
4a90c66 to
1c428e4
Compare
1c428e4 to
d689ee0
Compare
7 tasks
4 tasks
Member
Author
|
Replaced by #2824 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
nitropackrelease including this change to be updated innuxtPrimary motivation for adding runtime support is to actually to merge more test files 😂. Most if not all code for
detectBrowserLanguageis used at runtime, so there is no need to rebuild the project to test each options.nitrojs/nitro#1831 allows us to override runtime configs objects with environment variables, as this is currently not possible.
This PR changes the
@nuxt/test-utilscode further,startServernow optionally accepts additional environment variables. And I added helper functions to make setting runtime config variables via environment variables easier.Using the following in a test
Will be converted into
NUXT_PUBLIC_I18N_DETECT_BROWSER_LANGUAGE=falseand restarts the server with all properties in the passed object.📝 Checklist