feat: allow oveeridng nested runtime config with env#1831
Merged
pi0 merged 10 commits intonitrojs:mainfrom Nov 30, 2023
Merged
Conversation
pi0
reviewed
Oct 16, 2023
Member
|
This would be pretty useful, is there anything blocking this from being merged? |
TheAlexLichter
approved these changes
Nov 25, 2023
This was referenced Nov 25, 2023
TheAlexLichter
approved these changes
Nov 27, 2023
Member
|
Rebase/merge with main should make the tests pass again, this PR will enable more Nuxt modules to add support for more complex runtime configuration (have a PR lined up for Don't mean to rush anyone to merge this, but if I can be of any help to move it along let me know! |
Member
|
Thanks for PR ❤️ and sorry for late review since i needed to properly verify changes. |
pi0
approved these changes
Nov 30, 2023
8 tasks
4 tasks
Closed
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
fix #1830
❓ Type of change
📚 Description
Original behaviour
Runtime config properties with object type cannot be replaced by matching env variables.
Updated behaviour
Runtime config with object properties can be replaced by matching env variables.
📝 Checklist