Skip to content

fix(utils): check if holder is object in getProp util #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pi0 merged 1 commit into from
Dec 18, 2020
Merged

fix(utils): check if holder is object in getProp util #941

pi0 merged 1 commit into from
Dec 18, 2020

Conversation

@JoaoPedroAS51
Copy link
Collaborator

@JoaoPedroAS51 JoaoPedroAS51 commented Dec 18, 2020 •
edited
Loading

Fix "TypeError: Cannot use 'in' operator to search for 'token'"

Thanks to @CraftingGamerTom

Closes #699

@JoaoPedroAS51
fix(utils): check if holder is object in getProp util
c3ad2d6 
Fix "TypeError: Cannot use 'in' operator to search for 'token'"

Thanks to @CraftingGamerTom

Closes #699
@JoaoPedroAS51 JoaoPedroAS51 requested a review from pi0 December 18, 2020 05:42
@pi0 pi0 merged commit c5867c3 into dev Dec 18, 2020
@pi0 pi0 deleted the fix/utils branch December 18, 2020 08:29
@JoaoPedroAS51 JoaoPedroAS51 mentioned this pull request Dec 18, 2020
Merged
JoaoPedroAS51 added a commit that referenced this pull request Dec 18, 2020
@JoaoPedroAS51
fix(utils): check if holder is object in getProp util (#941)
b710269 
Fix "TypeError: Cannot use 'in' operator to search for 'token'"

Co-authored-by: Thomas Rokicki <tcrokicki@gmail.com>

Closes #699
pi0 pushed a commit that referenced this pull request Dec 18, 2020
@CraftingGamerTom @pi0
fix(utils): check if holder is object in getProp util (#941)
23ecb31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot use 'in' operator to search for 'token'

3 participants

@JoaoPedroAS51 @pi0