fix: regression from #385 when callback is set to false #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #391 +/- ##
===================================
Coverage 100% 100%
===================================
Files 1 1
Lines 2 2
===================================
Hits 2 2Continue to review full report at Codecov.
|
Member
|
Landed in 4.8.1 |
tanutsun
pushed a commit
to tanutsun/auth-module
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I commented in PR #385, I actually introduced a regression when
callback: falseis set in redirect options,as it tries to call
normalizePath(callback), which callscallback.split(), which is not possible when it is set tofalseinstead of astring.This PR fixes this.