Skip to content

fix: localhost link#1194

Merged
debs-obrien merged 2 commits intomasterfrom
fix-localhost-link
Jan 26, 2021
Merged

fix: localhost link#1194
debs-obrien merged 2 commits intomasterfrom
fix-localhost-link

Conversation

@debs-obrien
Copy link
Copy Markdown
Contributor

markdown/content module doesn't like the http inside the link text so removed it so it works correctly

markdown/content module doesn't like the http inside the link text so removed it so it works correctly
@debs-obrien
Copy link
Copy Markdown
Contributor Author

@benjamincanac it seems that content module isn't allowing me to add the link text with http and have had to make this pr to fix broken markdown links. Are you aware of this behaviour. this pr fixes it but I am sure it was working properly before. If you need me to submit an issue to content let me know.

@debs-obrien
Copy link
Copy Markdown
Contributor Author

@danielroe can you check this pr please. tests are failing in CI again but working locally only on this pr. Error from cypress is timeout rather than a link error like we had before so it might be just cypress going mad. Did re-run jobs and no luck. Any ideas?

cypress: https://github.com/nuxt/nuxtjs.org/pull/1194/checks?check_run_id=1762235229

@danielroe
Copy link
Copy Markdown
Member

As promised ✨

Copy link
Copy Markdown
Collaborator

@inouetakuya inouetakuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 👍

@debs-obrien debs-obrien merged commit 6f87976 into master Jan 26, 2021
@debs-obrien debs-obrien deleted the fix-localhost-link branch January 26, 2021 10:39
@rexwebmedia
Copy link
Copy Markdown
Contributor

Screenshot_2021-01-27-16-04-33-628

Its also on your blog article, and maybe at many more pages 😓

@debs-obrien
Copy link
Copy Markdown
Contributor Author

hi thanks for reporting. yes it seems to be an issue. trying to figure out whats causing it. Possibly a markdown issue in nuxt-edge as seems to have broken all links. @pi0 shall I transfer this issue to nuxt, fix all links manually or revert to earlier version to see if it fixes the markdown?

@pi0
Copy link
Copy Markdown
Member

pi0 commented Jan 27, 2021

Hi @debs-obrien. Issue seems also happening with 2.14.12. Made nuxt/content#737 with minimal reproduction for this.

@debs-obrien
Copy link
Copy Markdown
Contributor Author

Ok cool. Thanks @pi0. I had reached out to Ben first but he told me it wasn't a content thing. Perhaps the error has been there longer than we thought 🤷‍♀️

@pi0
Copy link
Copy Markdown
Member

pi0 commented Jan 27, 2021

There is a blackhole in node_modules 🤣 Regression is probably one of sub dependencies updated with yarn.lock.

If you know a commit that was fine, we may fallback yarn lock and compare what changed since

@AlexanderBelokon
Copy link
Copy Markdown

AlexanderBelokon commented Jan 28, 2021

You're right, @pi0, it is a regression in one of sub dependencies, more specifically in micromark-extension-gfm-autolink-literal @ 0.5.5. I've linked details in your issue.

pi0 added a commit that referenced this pull request Feb 10, 2021
@pi0 pi0 mentioned this pull request Feb 10, 2021
pi0 pushed a commit that referenced this pull request Jul 8, 2021
markdown/content module doesn't like the http inside the link text so removed it so it works correctly
imgbot bot pushed a commit that referenced this pull request Jan 10, 2023
markdown/content module doesn't like the http inside the link text so removed it so it works correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants