fix(config): merge app namespace rather than overriding#9039
Merged
Conversation
pi0
approved these changes
Mar 25, 2021
Member
pi0
left a comment
There was a problem hiding this comment.
Thanks. Makes sense for merging with runtimeConfig. However, we should probably discourage using this namespace to avoid internal conflicts...
enwin
pushed a commit
to enwin/nuxt.js
that referenced
this pull request
Mar 25, 2021
This was referenced Mar 30, 2021
Closed
Member
|
Reverted by #9075 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Note that
appshould be a reserved namespace in any case so this may be an abundance of caution.closes #8991
Checklist: