Skip to content

feat(generator): allow excluding exported routes using export:page hook#7455

Merged
pi0 merged 5 commits intonuxt:devfrom
farnabaz:hook_export
Jun 3, 2020
Merged

feat(generator): allow excluding exported routes using export:page hook#7455
pi0 merged 5 commits intonuxt:devfrom
farnabaz:hook_export

Conversation

@farnabaz
Copy link
Copy Markdown
Member

@farnabaz farnabaz commented Jun 2, 2020

close #7440

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 2, 2020

Codecov Report

Merging #7455 into dev will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7455      +/-   ##
==========================================
- Coverage   70.23%   70.22%   -0.02%     
==========================================
  Files          88       88              
  Lines        3699     3701       +2     
  Branches     1009     1010       +1     
==========================================
+ Hits         2598     2599       +1     
- Misses        893      894       +1     
  Partials      208      208              
Flag Coverage Δ
#unittests 70.22% <75.00%> (-0.02%) ⬇️
Impacted Files Coverage Δ
packages/generator/src/generator.js 85.07% <75.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8933d37...8e391aa. Read the comment docs.

@pi0 pi0 changed the title Change export:page hook for excluding page generation feat(generator): allow excluding exported routes using export:page hook Jun 2, 2020
atinux
atinux previously approved these changes Jun 3, 2020
@atinux
Copy link
Copy Markdown
Member

atinux commented Jun 3, 2020

Approved but missed the failing checks

path is fs/os dependent
Copy link
Copy Markdown
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@pi0 pi0 merged commit be726e4 into nuxt:dev Jun 3, 2020
@pi0 pi0 mentioned this pull request Jun 10, 2020
pi0 added a commit that referenced this pull request Jul 15, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to prevents page generation in generate:page

5 participants