Skip to content

ci: add --pnpm flag to correctly publish prerelease #33688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielroe merged 2 commits into from
Nov 10, 2025
Merged

ci: add --pnpm flag to correctly publish prerelease #33688

danielroe merged 2 commits into from
Nov 10, 2025

Conversation

@OrbisK
Copy link
Member

@OrbisK OrbisK commented Nov 10, 2025

🔗 Linked issue

Related to testing prerelease of #33446

📚 Description

This forces pr.pkg.new to use pnpm pack instead of npm pack.

This should fix errors like this:

In : "@nuxt/nitro-server@workspace:*" is in the dependencies but no package named "@nuxt/nitro-server" is present in the workspace

Should we handle the todo (# TODO: './packages/nitro-server')?

@OrbisK OrbisK requested a review from danielroe as a code owner November 10, 2025 15:19
@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Nov 10, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link

coderabbitai bot commented Nov 10, 2025 •
edited
Loading

Walkthrough

The .github/workflows/ci.yml workflow step release-pkg-new was updated: the pnpm pkg-pr-new publish command now includes the --pnpm flag and the ./packages/nitro-server path was added to the list of publish targets (a prior placeholder comment for nitro-server was removed). No other logic or steps were changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single workflow file change with a small CLI-argument addition and one extra package path
  • No code logic or structural changes
  • Quick review points:
    • Verify the ./packages/nitro-server path/package exists and is intended to be published
    • Confirm --pnpm is the desired flag for this publish command in CI context

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding the --pnpm flag to the CI workflow for publishing prerelease packages, which directly corresponds to the command modification shown in the changeset.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of adding the --pnpm flag and the specific problem it solves regarding workspace package resolution errors.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7495a85 and d6b11c7.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Nov 10, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)

393-394: Clarify the unresolved TODO about ./packages/nitro-server.

Line 393 introduces a TODO comment, but it remains unresolved. This suggests uncertainty about how to handle ./packages/nitro-server. Given that the PR objectives mention fixing workspace dependency errors for this package, please clarify:

  • Should ./packages/nitro-server be added to the package paths list on line 394?
  • Or does the --pnpm flag handle this package implicitly?
  • Is this TODO intended to be addressed in a follow-up PR, or should it be resolved as part of this change?

If nitro-server should be included, I can help generate the corrected command.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d2c9711 and 7495a85.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-11-11T12:34:22.648Z 
Learnt from: Tofandel
Repo: nuxt/nuxt PR: 0
File: :0-0
Timestamp: 2024-11-11T12:34:22.648Z
Learning: Ensure that AI-generated summaries accurately reflect the key changes in the PR, focusing on notable changes such as the removal of unused imports and variables starting with underscores.

Applied to files:

  • .github/workflows/ci.yml
🔇 Additional comments (1)
.github/workflows/ci.yml (1)

394-394: The --pnpm flag is correctly configured.

Based on the documentation, the --pnpm flag is a valid and documented option for pkg-pr-new that directs it to use pnpm pack instead of the default npm pack. The flag can be used in workflows as npx pkg-pr-new publish --pnpm, and your placement between --compact and the package paths is correct.

Using pnpm pack instead of npm pack is the appropriate choice for this pnpm workspace project, as it properly understands pnpm's workspace:* protocol dependencies. This resolves the workspace dependency resolution issue mentioned in the PR objectives.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 10, 2025 •
edited
Loading

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33688

@nuxt/nitro-server

npm i https://pkg.pr.new/@nuxt/nitro-server@33688

nuxt

npm i https://pkg.pr.new/nuxt@33688

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33688

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33688

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33688

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33688

commit: d6b11c7

danielroe
danielroe reviewed Nov 10, 2025
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed!

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 10, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #33688 will not alter performance

Comparing OrbisK:ci/prerelease-pnpm (d6b11c7) with main (d2c9711)

Summary

✅ 10 untouched

@danielroe danielroe merged commit ce14d05 into nuxt:main Nov 10, 2025
99 of 100 checks passed
@github-actions github-actions bot mentioned this pull request Nov 10, 2025
Merged
danielroe pushed a commit that referenced this pull request Nov 11, 2025
@OrbisK @danielroe
ci: add --pnpm flag to correctly publish prerelease (#33688)
0171c8c
@github-actions github-actions bot mentioned this pull request Nov 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

4.x chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OrbisK @danielroe