Skip to content

fix(nitro): remove <nuxt-error-overlay> iframe border #33625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielroe merged 1 commit into from
Nov 1, 2025
Merged

fix(nitro): remove <nuxt-error-overlay> iframe border #33625

danielroe merged 1 commit into from
Nov 1, 2025

Conversation

@L33Z22L11
Copy link
Contributor

@L33Z22L11 L33Z22L11 commented Nov 1, 2025

🔗 Linked issue

📚 Description

Remove iframe border for <nuxt-error-overlay>.

Fullscreen Inert
Before QQ_1761979029397 QQ_1761979069351
After QQ_1761979178860 QQ_1761979222453

BTW, the white line in the right of the iframe button is youch's scrollbar (poppinss/youch#80).

@L33Z22L11 L33Z22L11 requested a review from danielroe as a code owner November 1, 2025 07:24
@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Nov 1, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link

coderabbitai bot commented Nov 1, 2025 •
edited
Loading

Walkthrough

The pull request modifies a single file in the Nitro server utilities to adjust the error display styling. Specifically, a CSS property (border: none;) has been added to the #frame style rule within the errorCSS variable. This change removes the default border rendering around the iframe element used for error presentation. The modification is purely visual with no impact on runtime behaviour or functionality.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

This is a minimal, single-file change consisting of a straightforward CSS property addition with no logic modifications or complex interactions to consider.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed The pull request description is directly related to the changeset, stating "Remove iframe border for <nuxt-error-overlay>" and providing before and after screenshots that demonstrate the visual change. The description includes helpful context about the scrollbar artefact being from youch, and whilst it lacks a linked issue number, it contains sufficient relevant information about the change being made. The description is neither vague nor off-topic, and clearly conveys the intent of the modification.
Title Check ✅ Passed The pull request title "fix(nitro): remove <nuxt-error-overlay> iframe border" directly and accurately describes the main change in the changeset. The raw summary confirms that the modification adds border: none; to the #frame style in errorCSS to remove the default iframe border, which is precisely what the title states. The title is concise, specific, follows conventional commit format conventions, and avoids vague or generic language. A teammate scanning the repository history would immediately understand that this changeset addresses a visual fix for the error overlay component's border styling.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 1, 2025

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33625

nuxt

npm i https://pkg.pr.new/nuxt@33625

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33625

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33625

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33625

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33625

commit: c2011b0

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 1, 2025

CodSpeed Performance Report

Merging #33625 will not alter performance

Comparing L33Z22L11:fix/nuxt-error-overlay-border (c2011b0) with main (456cc36)

Summary

✅ 10 untouched

@danielroe danielroe changed the title fix(nitro,nuxt): remove <nuxt-error-overlay> iframe border fix(nitro): remove <nuxt-error-overlay> iframe border Nov 1, 2025
@danielroe
Copy link
Member

danielroe commented Nov 1, 2025

thank you 🙏

@danielroe danielroe merged commit 89f59b7 into nuxt:main Nov 1, 2025
100 of 102 checks passed
@github-actions github-actions bot mentioned this pull request Oct 31, 2025
Merged
danielroe pushed a commit that referenced this pull request Nov 6, 2025
@L33Z22L11 @danielroe
fix(nitro): remove <nuxt-error-overlay> iframe border (#33625)
9b2b417
@github-actions github-actions bot mentioned this pull request Nov 6, 2025
Merged
This was referenced Nov 7, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 8, 2025
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OrbisK OrbisK OrbisK approved these changes

@danielroe danielroe Awaiting requested review from danielroe danielroe is a code owner

+1 more reviewer

@KazariEX KazariEX KazariEX approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4.x bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@L33Z22L11 @danielroe @OrbisK @KazariEX