fix(nuxt): preserve root route in `isPrerendered` check #33476

Flo0806 · 2025-10-13T16:56:46Z

🔗 Linked issue

📚 Description

Fixes root route (/) payload not loading during client-side navigation.

📝 Description

When navigating back to the root route / using <NuxtLink>, the prerendered payload was not being loaded. This caused useAsyncData callbacks to re-execute instead of using the cached payload data.
Root cause: The isPrerendered() function was converting / to an empty string '' when normalizing URLs, causing the manifest lookup to fail.
Solution: Updated the regex pattern from /\/$/ to /(?<=.)\/$$/ to only strip trailing slashes when there's at least one character before it, preserving the root route.

📦 Changes

Updated three files to use the new regex pattern consistently:

packages/nuxt/src/app/composables/payload.ts - isPrerendered() function
packages/nuxt/src/core/runtime/nitro/renderer.ts - payload cache key
packages/nuxt/src/app/plugins/router/scrollBehavior.client.ts - route comparison

✅ Checklist

All existing tests pass
No new tests needed (existing tests cover the functionality)

🧪 How to test

Create a Nuxt app with prerendering enabled
Run pnpm play:generate && pnpm play:preview
Navigate from / → /page → /
Verify that useAsyncData doesn't re-execute on navigation back to /

bolt-new-by-stackblitz · 2025-10-13T16:56:49Z

Run & review this pull request in StackBlitz Codeflow.

danielroe · 2025-10-13T16:58:33Z

packages/nuxt/src/pages/runtime/router.options.ts


    // Hash routes on the same page, no page hook is fired so resolve here
-    if (to.path.replace(/\/$/, '') === from.path.replace(/\/$/, '')) {
+    if (to.path.replace(/(?<=.)\/$/, '') === from.path.replace(/(?<=.)\/$/, '')) {


we probably don't need to update here as all we care about is equality

Yes... right. Should I revert it back and commit again?

yes please 🙏

With pleasure, and thank you for allowing me to participate!

pkg-pr-new · 2025-10-13T17:00:25Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33476

nuxt

npm i https://pkg.pr.new/nuxt@33476

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33476

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33476

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33476

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33476

commit: a1488aa

coderabbitai · 2025-10-13T17:01:24Z

Caution

Review failed

The pull request is closed.

Walkthrough

Changes adjust handling of trailing slashes for root paths. In packages/nuxt/src/app/composables/payload.ts, isPrerendered now preserves "/" and only trims a trailing slash for non-root URLs, affecting manifest/prerender checks accordingly. In packages/nitro-server/src/runtime/handlers/renderer.ts, the cache key for the root route is updated from an empty string to "/" while keeping trailing-slash trimming for other URLs. No public API surface changes are introduced.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly and accurately describes the main change of preserving the root route in the isPrerendered check, matching the code modifications and bug fix.
Linked Issues Check	✅ Passed	The changes directly address the linked issue by updating the trailing-slash regex in the isPrerendered function, payload cache key, and scroll behaviour comparison to preserve the root path and ensure the prerendered payload for "/" is correctly detected and used during client-side navigation.
Out of Scope Changes Check	✅ Passed	All modifications are confined to normalising trailing slashes in functions related to prerendered payload and route comparison, with no unrelated or extraneous changes introduced outside the scope of preserving the root route payload.
Description Check	✅ Passed	The description clearly outlines the linked issue, root cause, solution, and impacted files, directly relating to the changes in normalising the root route in payload handling.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a1488aa and 1b05990.

📒 Files selected for processing (1)

packages/nitro-server/src/runtime/handlers/renderer.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codspeed-hq · 2025-10-13T17:11:37Z

CodSpeed Performance Report

Merging #33476 will not alter performance

_{Comparing Flo0806:fix/isprerendered-root-route (1b05990) with main (f3dc078)}

Summary

✅ 10 untouched

…'t need normalization

packages/nuxt/src/app/composables/payload.ts

danielroe · 2025-10-13T20:44:13Z

thank you again ❤️

…t-route

fix(app): preserve root route in isPrerendered check - fixes nuxt#33443

3efab09

Flo0806 requested a review from danielroe as a code owner October 13, 2025 16:56

github-actions bot added 4.x bug labels Oct 13, 2025

danielroe approved these changes Oct 13, 2025

View reviewed changes

Flo0806 changed the title ~~fix(app): preserve root route in isPrerendered check (#33443)~~ fix(nuxt): preserve root route in isPrerendered check Oct 13, 2025

revert: keep original regex in scrollBehavior as equality check doesn…

94c7094

…'t need normalization

danielroe reviewed Oct 13, 2025

View reviewed changes

packages/nuxt/src/app/composables/payload.ts Outdated Show resolved Hide resolved

fix(payload): drop regex lookbehind in cache key

a1488aa

danielroe approved these changes Oct 13, 2025

View reviewed changes

Merge remote-tracking branch 'origin/main' into fix/isprerendered-roo…

1b05990

…t-route

danielroe merged commit f836eca into nuxt:main Oct 13, 2025
6 checks passed

github-actions bot mentioned this pull request Oct 13, 2025

v4.2.0 #33425

Merged

s1gr1d mentioned this pull request Oct 17, 2025

nuxt-4 (canary) Test Failed getsentry/sentry-javascript#17960

Closed

github-actions bot mentioned this pull request Oct 23, 2025

v5.0.0 #33548

Closed

danielroe pushed a commit that referenced this pull request Oct 25, 2025

fix(nuxt): preserve root route in isPrerendered check (#33476)

074fe9e

github-actions bot mentioned this pull request Oct 25, 2025

v3.20.0 #33566

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(nuxt): preserve root route in `isPrerendered` check #33476

fix(nuxt): preserve root route in `isPrerendered` check #33476

Uh oh!

Flo0806 commented Oct 13, 2025

Uh oh!

bolt-new-by-stackblitz bot commented Oct 13, 2025

Uh oh!

danielroe Oct 13, 2025

Uh oh!

Flo0806 Oct 13, 2025

Uh oh!

danielroe Oct 13, 2025

Uh oh!

Flo0806 Oct 13, 2025

Uh oh!

pkg-pr-new bot commented Oct 13, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 13, 2025 •

edited

Loading

Review failed

Uh oh!

codspeed-hq bot commented Oct 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

danielroe commented Oct 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(nuxt): preserve root route in isPrerendered check #33476

fix(nuxt): preserve root route in isPrerendered check #33476

Uh oh!

Conversation

Flo0806 commented Oct 13, 2025

🔗 Linked issue

📚 Description

📝 Description

📦 Changes

✅ Checklist

🧪 How to test

Uh oh!

bolt-new-by-stackblitz bot commented Oct 13, 2025

Uh oh!

danielroe Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Flo0806 Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

danielroe Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Flo0806 Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

codspeed-hq bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #33476 will not alter performance

Summary

Uh oh!

Uh oh!

danielroe commented Oct 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(nuxt): preserve root route in `isPrerendered` check #33476

fix(nuxt): preserve root route in `isPrerendered` check #33476

pkg-pr-new bot commented Oct 13, 2025 •

edited

Loading

coderabbitai bot commented Oct 13, 2025 •

edited

Loading

codspeed-hq bot commented Oct 13, 2025 •

edited

Loading