fix(nuxt): do not relativise importmap if `cdnURL` is set #33333

danielroe · 2025-09-27T08:47:46Z

🔗 Linked issue

resolves #33266

📚 Description

if cdnURL is set it isn't going to be a relative path so we can skip checking/relativising the app

bolt-new-by-stackblitz · 2025-09-27T08:47:50Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-09-27T08:49:54Z

Walkthrough

In packages/nuxt/src/core/runtime/nitro/handlers/renderer.ts, the import of hasProtocol from 'ufo' was removed. The logic deciding whether to cache entryPath versus relativise it was updated: entryPath is now cached when ssrContext.runtimeConfig.app.cdnURL is truthy, in addition to the existing absolute/relative path consideration. This replaces the prior reliance on hasProtocol to determine caching behaviour.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title accurately reflects the core fix of preventing importmap relativisation when a CDN URL is configured, which matches the changes in the handler logic without extraneous details.
Linked Issues Check	✅ Passed	The update adds a guard that skips importmap relativisation whenever `app.cdnURL` is configured, fulfilling the requirement to avoid a leading `./` for placeholder or non-http CDN URLs as described in issue #33266.
Out of Scope Changes Check	✅ Passed	The only modifications are within the importmap rendering logic in `renderer.ts` to incorporate the `cdnURL` check, and no unrelated files or features were altered outside the scope of the linked issue.
Description Check	✅ Passed	The description directly references the linked issue and clearly explains that setting `cdnURL` should bypass path relativisation, which aligns with the implemented change.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/cdn-path

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7acb972 and caa58fc.

📒 Files selected for processing (1)

packages/nuxt/src/core/runtime/nitro/handlers/renderer.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Follow standard TypeScript conventions and best practices

Files:

packages/nuxt/src/core/runtime/nitro/handlers/renderer.ts

🧠 Learnings (2)

📓 Common learnings

Learnt from: GalacticHypernova
PR: nuxt/nuxt#26468
File: packages/nuxt/src/components/plugins/loader.ts:24-24
Timestamp: 2024-11-05T15:22:54.759Z
Learning: In `packages/nuxt/src/components/plugins/loader.ts`, the references to `resolve` and `distDir` are legacy code from before Nuxt used the new unplugin VFS and will be removed.

Learnt from: huang-julien
PR: nuxt/nuxt#29366
File: packages/nuxt/src/app/components/nuxt-root.vue:16-19
Timestamp: 2024-12-12T12:36:34.871Z
Learning: In `packages/nuxt/src/app/components/nuxt-root.vue`, when optimizing bundle size by conditionally importing components based on route metadata, prefer using inline conditional imports like:

```js
const IsolatedPage = route?.meta?.isolate ? defineAsyncComponent(() => import('#build/isolated-page.mjs')) : null
```

instead of wrapping the import in a computed property or importing the component unconditionally.

📚 Learning: 2024-11-05T15:22:54.759Z

Learnt from: GalacticHypernova
PR: nuxt/nuxt#26468
File: packages/nuxt/src/components/plugins/loader.ts:24-24
Timestamp: 2024-11-05T15:22:54.759Z
Learning: In `packages/nuxt/src/components/plugins/loader.ts`, the references to `resolve` and `distDir` are legacy code from before Nuxt used the new unplugin VFS and will be removed.

Applied to files:

packages/nuxt/src/core/runtime/nitro/handlers/renderer.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)

GitHub Check: test-fixtures (windows-latest, dev, vite, default, manifest-off, json, lts/-1)
GitHub Check: test-fixtures (windows-latest, built, vite, default, manifest-off, json, lts/-1)
GitHub Check: test-fixtures (windows-latest, built, vite, async, manifest-off, json, lts/-1)
GitHub Check: test-fixtures (windows-latest, dev, vite, async, manifest-off, json, lts/-1)
GitHub Check: test-fixtures (ubuntu-latest, built, webpack, default, manifest-on, json, lts/-1)
GitHub Check: test-fixtures (ubuntu-latest, built, vite, default, manifest-off, json, lts/-1)
GitHub Check: test-fixtures (ubuntu-latest, built, vite, default, manifest-on, json, lts/-1)
GitHub Check: test-fixtures (ubuntu-latest, built, webpack, async, manifest-on, json, lts/-1)
GitHub Check: test-fixtures (ubuntu-latest, dev, vite, async, manifest-on, js, lts/-1)
GitHub Check: test-fixtures (ubuntu-latest, dev, vite, default, manifest-off, json, lts/-1)
GitHub Check: test-fixtures (ubuntu-latest, dev, vite, async, manifest-off, json, lts/-1)
GitHub Check: test-fixtures (ubuntu-latest, built, vite, async, manifest-on, json, lts/-1)
GitHub Check: test-fixtures (ubuntu-latest, dev, vite, async, manifest-on, json, lts/-1)
GitHub Check: test-fixtures (ubuntu-latest, dev, vite, default, manifest-on, json, lts/-1)
GitHub Check: release-pkg-pr-new
GitHub Check: test-size
GitHub Check: test-benchmark
GitHub Check: typecheck (windows-latest, bundler)
GitHub Check: typecheck (ubuntu-latest, bundler)
GitHub Check: code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2025-09-27T08:55:33Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33333

nuxt

npm i https://pkg.pr.new/nuxt@33333

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33333

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33333

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33333

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33333

commit: caa58fc

codspeed-hq · 2025-09-27T09:07:26Z

CodSpeed Performance Report

Merging #33333 will not alter performance

_{Comparing fix/cdn-path (caa58fc) with main (3e4a999)¹}

Summary

✅ 10 untouched

No successful run was found on main (2d63479) during the generation of this report, so 3e4a999 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

fix(nuxt): do not relativise importmap if cdnURL is set

e76a0ea

github-actions bot added 4.x bug labels Sep 27, 2025

danielroe added 2 commits September 27, 2025 12:16

test: remove cdn url from test

7acb972

fix: reverse regexp condition for relative path

caa58fc

danielroe merged commit 910d159 into main Sep 27, 2025
188 of 195 checks passed

danielroe deleted the fix/cdn-path branch September 27, 2025 11:33

github-actions bot mentioned this pull request Sep 27, 2025

v4.1.3 #33235

Merged

danielroe added a commit that referenced this pull request Oct 6, 2025

fix(nuxt): do not relativise importmap if cdnURL is set (#33333)

c9f4575

github-actions bot mentioned this pull request Oct 6, 2025

v3.19.3 #33269

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(nuxt): do not relativise importmap if `cdnURL` is set #33333

fix(nuxt): do not relativise importmap if `cdnURL` is set #33333

Uh oh!

danielroe commented Sep 27, 2025

Uh oh!

bolt-new-by-stackblitz bot commented Sep 27, 2025

Uh oh!

coderabbitai bot commented Sep 27, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Sep 27, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Sep 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(nuxt): do not relativise importmap if cdnURL is set #33333

fix(nuxt): do not relativise importmap if cdnURL is set #33333

Uh oh!

Conversation

danielroe commented Sep 27, 2025

🔗 Linked issue

📚 Description

Uh oh!

bolt-new-by-stackblitz bot commented Sep 27, 2025

Uh oh!

coderabbitai bot commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

pkg-pr-new bot commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #33333 will not alter performance

Summary

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(nuxt): do not relativise importmap if `cdnURL` is set #33333

fix(nuxt): do not relativise importmap if `cdnURL` is set #33333

coderabbitai bot commented Sep 27, 2025 •

edited

Loading

pkg-pr-new bot commented Sep 27, 2025 •

edited

Loading

codspeed-hq bot commented Sep 27, 2025 •

edited

Loading