perf(nuxt): use granular imports for auto-importing composables#23951
Merged
perf(nuxt): use granular imports for auto-importing composables#23951
Conversation
|
|
Contributor
✅ Live Preview ready!
|
This reverts commit 3c586ca.
Merged
10 tasks
6 tasks
This was referenced Nov 7, 2023
This was referenced Nov 8, 2023
josecelano
added a commit
to torrust/torrust-index-gui
that referenced
this pull request
Nov 8, 2023
21787f9 fix: import nuxt composables from #imports (Daniel Roe) Pull request description: This is a DX improvement when developing - we can avoid loading the entire barrel file at `#app` by using the new granular imports merged in nuxt/nuxt#23951. ACKs for top commit: josecelano: ACK 21787f9 Tree-SHA512: a238f9a80e7be8b3a54b9b4637c4371e1b81fb507aa9a20cca5b9344f5dfe4b886588bfc7f22cdd74b30a391a661d4221cc9915bfc1ebe9eba61c24d8a08216a
Member
|
@danielroe Is really on a roll providing PRs to all the public repos that will benefit from that change. Amazing job 👏🏻 |
Member
Author
|
❤️ |
This was referenced Nov 8, 2023
fbjork
added a commit
to grafbase/grafbase
that referenced
this pull request
Nov 8, 2023
# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. # Type of change - [ ] 💔 Breaking - [ ] 🚀 Feature - [x] 🐛 Fix - [ ] 🛠️ Tooling - [ ] 🔨 Refactoring - [ ] 🧪 Test - [ ] 📦 Dependency - [ ] 📖 Requires documentation update This is a DX improvement when developing - we can avoid loading the entire barrel file at `#app` by using the new granular imports merged in nuxt/nuxt#23951.
7 tasks
TheAlexLichter
pushed a commit
that referenced
this pull request
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
This PR aims to improve Vite HMR + cold start/warmup performance by reducing crawling of unneeded files in the nuxt app:
#app)📝 Checklist