This repository was archived by the owner on Apr 6, 2023. It is now read-only.
Merged
Conversation
|
|
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
reviewed
Oct 18, 2022
| // @ts-ignore | ||
| globalThis.__buildAssetsURL = buildAssetsURL | ||
| // @ts-ignore | ||
| globalThis.__publicAssetsURL = publicAssetsURL |
Member
There was a problem hiding this comment.
Wouldn't they register as side-effects of #paths? (and if they do, do we still need it from #paths?
Member
Author
There was a problem hiding this comment.
They aren't registered as globals there.
And yes, we probably could wrap these lines in if (process.client) - will try:
framework/packages/nuxt/src/core/templates.ts
Lines 243 to 244 in c404cb1
pi0
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#14953
❓ Type of change
📚 Description
With nuxt-contrib/vue-bundle-renderer#39, we are now not blocking render with stylesheet, but we still need to load entry CSS on client side to include client-only CSS (among other things). This PR:
ssr: falseroutes: fix(nuxt): don't inline styles for per-requestssr: false#8106📝 Checklist