This repository was archived by the owner on Apr 6, 2023. It is now read-only.
perf(vite): do not resolve module field for packages#2636
Merged
Conversation
|
✔️ Deploy Preview for nuxt3-docs ready! 🔨 Explore the source changes: e0ca661 🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/61dddc36364f7400084e51d3 😎 Browse the preview: https://deploy-preview-2636--nuxt3-docs.netlify.app |
pi0
reviewed
Jan 7, 2022
Co-authored-by: pooya parsa <pyapar@gmail.com>
antfu
commented
Jan 7, 2022
pi0
reviewed
Jan 10, 2022
pi0
reviewed
Jan 11, 2022
pi0
approved these changes
Jan 11, 2022
Member
|
Changes temporary reverted because of regression discussed in nuxt/nuxt#13196 |
Member
Author
|
Ah sorry for that. I think it also requires some additional logic to interop the default, I will include that in the upcoming refactor of using on-demand module evaluation |
danielroe
added a commit
that referenced
this pull request
Jan 13, 2022
This reverts commit a2e2e04.
danielroe
added a commit
that referenced
this pull request
Jan 17, 2022
This reverts commit a2e2e04.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
https://github.com/vitejs/vite/blob/04016df8beb7110ad2087ada8e1abbefdbd70254/packages/vite/src/node/constants.ts#L3-L7
We have confirmed this works for Vitest and sloved many issues we had.
📝 Checklist